Seperated exception Codes (const in OrderExceptionCodes class), Renam…

…ed Exception class "OrderUnknownDateFormat" to "OrderUnknownDateFormatException"
horstoeko · Jan 12, 2023 · fb78024 · fb78024
1 parent 8c62bea
commit fb78024
Show file tree

Hide file tree

Showing 11 changed files with 35 additions and 15 deletions.
diff --git a/src/OrderObjectHelper.php b/src/OrderObjectHelper.php
@@ -11,7 +11,7 @@
 
 use DateTime;
 use horstoeko\orderx\exception\OrderMimeTypeNotSupportedException;
-use horstoeko\orderx\exception\OrderUnknownDateFormat;
+use horstoeko\orderx\exception\OrderUnknownDateFormatException;
 use horstoeko\stringmanagement\FileUtils;
 use horstoeko\stringmanagement\StringUtils;
 use MimeTyper\Repository\MimeDbRepository;
@@ -1319,7 +1319,7 @@ public function toDateTime(?string $dateTimeString = null, ?string $format = nul
         } elseif ($format == "204") {
             return DateTime::createFromFormat("YmdHis", $dateTimeString);
         } else {
-            throw new OrderUnknownDateFormat($format);
+            throw new OrderUnknownDateFormatException($format);
         }
     }
 

diff --git a/src/exception/OrderCannotFindProfileString.php b/src/exception/OrderCannotFindProfileString.php
@@ -29,6 +29,6 @@ class OrderCannotFindProfileString extends OrderBaseException
      */
     public function __construct(?Throwable $previous = null)
     {
-        parent::__construct("The string containing the profile was not found", -1101, $previous);
+        parent::__construct("The string containing the profile was not found", OrderExceptionCodes::CANNOTFINDPROFILESTRING, $previous);
     }
 }
diff --git a/src/exception/OrderExceptionCodes.php b/src/exception/OrderExceptionCodes.php
@@ -0,0 +1,20 @@
+<?php
+
+/**
+ * This file is a part of horstoeko/orderx.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace horstoeko\orderx\exception;
+
+class OrderExceptionCodes
+{
+    public const CANNOTFINDPROFILESTRING = -1101;
+    public const UNKNOWNPROFILE = -1102;
+    public const MIMETYPENOTSUPPORTED = -1103;
+    public const UNKNOWNDATEFORMAT = -1104;
+    public const NOVALIDATTACHMENTFOUNDINPDF = -1105;
+    public const FILENOTFOUND = -2000;
+}
diff --git a/src/exception/OrderFileNotFoundException.php b/src/exception/OrderFileNotFoundException.php
@@ -30,6 +30,6 @@ class OrderFileNotFoundException extends OrderBaseException
      */
     public function __construct(string $filename, ?Throwable $previous = null)
     {
-        parent::__construct(sprintf("The file %s was not found", $filename), -2000, $previous);
+        parent::__construct(sprintf("The file %s was not found", $filename), OrderExceptionCodes::FILENOTFOUND, $previous);
     }
 }
diff --git a/src/exception/OrderMimeTypeNotSupportedException.php b/src/exception/OrderMimeTypeNotSupportedException.php
@@ -30,6 +30,6 @@ class OrderMimeTypeNotSupportedException extends OrderBaseException
      */
     public function __construct(string $mimetype, ?Throwable $previous = null)
     {
-        parent::__construct(sprintf("The Mime Type %s is not supported", $mimetype), -1103, $previous);
+        parent::__construct(sprintf("The Mime Type %s is not supported", $mimetype), OrderExceptionCodes::MIMETYPENOTSUPPORTED, $previous);
     }
 }
diff --git a/src/exception/OrderNoValidAttachmentFoundInPdfException.php b/src/exception/OrderNoValidAttachmentFoundInPdfException.php
@@ -29,6 +29,6 @@ class OrderNoValidAttachmentFoundInPdfException extends OrderBaseException
      */
     public function __construct(?Throwable $previous = null)
     {
-        parent::__construct("No valid attachment file found in PDF", -1105, $previous);
+        parent::__construct("No valid attachment file found in PDF", OrderExceptionCodes::NOVALIDATTACHMENTFOUNDINPDF, $previous);
     }
 }
diff --git a/src/exception/OrderUnknownDateFormat.php → ...ption/OrderUnknownDateFormatException.php b/src/exception/OrderUnknownDateFormat.php → ...ption/OrderUnknownDateFormatException.php
@@ -21,7 +21,7 @@
  * @license  https://opensource.org/licenses/MIT MIT
  * @link     https://github.com/horstoeko/orderx
  */
-class OrderUnknownDateFormat extends OrderBaseException
+class OrderUnknownDateFormatException extends OrderBaseException
 {
     /**
      * Constructor
@@ -30,6 +30,6 @@ class OrderUnknownDateFormat extends OrderBaseException
      */
     public function __construct(string $dateFormatCode, ?Throwable $previous = null)
     {
-        parent::__construct(sprintf("Invalid date format %s", $dateFormatCode), -1104, $previous);
+        parent::__construct(sprintf("Invalid date format %s", $dateFormatCode), OrderExceptionCodes::UNKNOWNDATEFORMAT, $previous);
     }
 }
diff --git a/src/exception/OrderUnknownProfileException.php b/src/exception/OrderUnknownProfileException.php
@@ -30,6 +30,6 @@ class OrderUnknownProfileException extends OrderBaseException
      */
     public function __construct(string $profileString, ?Throwable $previous = null)
     {
-        parent::__construct(sprintf("Cannot determain the profile by %s", $profileString), -1102, $previous);
+        parent::__construct(sprintf("Cannot determain the profile by %s", $profileString), OrderExceptionCodes::UNKNOWNPROFILE, $previous);
     }
 }
diff --git a/tests/testcases/OrderObjectHelperBasicTest.php b/tests/testcases/OrderObjectHelperBasicTest.php
@@ -2,7 +2,7 @@
 
 namespace horstoeko\orderx\tests\testcases;
 
-use horstoeko\orderx\exception\OrderUnknownDateFormat;
+use horstoeko\orderx\exception\OrderUnknownDateFormatException;
 use horstoeko\orderx\OrderObjectHelper;
 use horstoeko\orderx\OrderProfiles;
 use horstoeko\orderx\tests\TestCase;
@@ -1120,7 +1120,7 @@ public function testToDateTime(): void
         $this->assertEquals("31.12.2022 14:30:00", self::$objectHelper->toDateTime("202212311430", "203")->format("d.m.Y H:i:s"));
         $this->assertEquals("31.12.2022 14:30:44", self::$objectHelper->toDateTime("20221231143044", "204")->format("d.m.Y H:i:s"));
 
-        $this->expectException(OrderUnknownDateFormat::class);
+        $this->expectException(OrderUnknownDateFormatException::class);
         self::$objectHelper->toDateTime("20221231", "999");
     }
 

diff --git a/tests/testcases/OrderObjectHelperComfortTest.php b/tests/testcases/OrderObjectHelperComfortTest.php
@@ -3,7 +3,7 @@
 namespace horstoeko\orderx\tests\testcases;
 
 use horstoeko\orderx\exception\OrderMimeTypeNotSupportedException;
-use horstoeko\orderx\exception\OrderUnknownDateFormat;
+use horstoeko\orderx\exception\OrderUnknownDateFormatException;
 use horstoeko\orderx\OrderObjectHelper;
 use horstoeko\orderx\OrderProfiles;
 use horstoeko\orderx\tests\TestCase;
@@ -1202,7 +1202,7 @@ public function testToDateTime(): void
         $this->assertEquals("31.12.2022 14:30:00", self::$objectHelper->toDateTime("202212311430", "203")->format("d.m.Y H:i:s"));
         $this->assertEquals("31.12.2022 14:30:44", self::$objectHelper->toDateTime("20221231143044", "204")->format("d.m.Y H:i:s"));
 
-        $this->expectException(OrderUnknownDateFormat::class);
+        $this->expectException(OrderUnknownDateFormatException::class);
         self::$objectHelper->toDateTime("20221231", "999");
     }
 

diff --git a/tests/testcases/OrderObjectHelperExtendedTest.php b/tests/testcases/OrderObjectHelperExtendedTest.php
@@ -3,7 +3,7 @@
 namespace horstoeko\orderx\tests\testcases;
 
 use horstoeko\orderx\exception\OrderMimeTypeNotSupportedException;
-use horstoeko\orderx\exception\OrderUnknownDateFormat;
+use horstoeko\orderx\exception\OrderUnknownDateFormatException;
 use horstoeko\orderx\OrderObjectHelper;
 use horstoeko\orderx\OrderProfiles;
 use horstoeko\orderx\tests\TestCase;
@@ -1226,7 +1226,7 @@ public function testToDateTime(): void
         $this->assertEquals("31.12.2022 14:30:00", self::$objectHelper->toDateTime("202212311430", "203")->format("d.m.Y H:i:s"));
         $this->assertEquals("31.12.2022 14:30:44", self::$objectHelper->toDateTime("20221231143044", "204")->format("d.m.Y H:i:s"));
 
-        $this->expectException(OrderUnknownDateFormat::class);
+        $this->expectException(OrderUnknownDateFormatException::class);
         self::$objectHelper->toDateTime("20221231", "999");
     }