- Refactor test_basemap.py and add additional boundary handler tests #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonaldRonnie
changed the title
setup_boundary fixture for test
|
Thanks @RonaldRonnie ! Sorry for the delay in review - I will check the code over now 👍 Related to #203 |
spwoodcock
requested changes
Aug 5, 2024
|
Also, apologies but the test_basemap.py file is out of sync with the main branch. Could you merge in the main branch and resolve conflicts please? |
|
Thank you @spwoodcock for the feedback. So should I first work again on the tests? any advice about this |
|
For sure! If you resolved all the issues and push your latest code, I can review it again and merge 😄 |
|
Thank you @spwoodcock , do i have to first close the PR here and the make another one? |
spwoodcock
approved these changes
Aug 13, 2024
|
I will be pleased for the feedback |
setup. - Added GeoJSON boundary setup and included BytesIO. - Expanded `test_create` to include tile generation for levels 8 to 12. - Enhanced PMTile validation with specific zoom level assertion. - Removed `test_init_with_bytesio` in `TestBoundaryHandlerFactory` due to an AttributeError. - Added tests for bounding box creation in `BytesIOBoundaryHandler` and `StringBoundaryHandler` classes. - Included validation tests for invalid and empty boundary strings. - Updated test methods to improve clarity and coverage.
This update has been made to remove the useless / unnecessary code tests
This update (fix) address and has been made to after removing the unwanted /useless or unnecessary tests from the PR
|
Sorry it took so long to test this! Everything works great 🙏 |
for more information, see https://pre-commit.ci
|
thank you. Am humbled
…On Mon, 19 Aug 2024 at 14:50, Sam ***@***.***> wrote:
Sorry it took so long to test this!
Everything works great 🙏
Nice work 😄
—
Reply to this email directly, view it on GitHub
<#280 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBVREP5RY3BEJRJBTZMFW4LZSHLZTAVCNFSM6AAAAABL25ZZFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGM4DMNRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.
BytesIO.
test_createto include tilegeneration for levels 8 to 12.
level assertion.
test_init_with_bytesioinTestBoundaryHandlerFactorydue to anAttributeError.
BytesIOBoundaryHandlerandStringBoundaryHandlerclasses.boundary strings.
coverage.