Skip to content

Commit

Permalink
Merge pull request #233 from hotwired/toolbar_height_fix
Browse files Browse the repository at this point in the history
Replace hardcoded toolbar heights in fragment layouts with wrap_content
  • Loading branch information
jayohms authored Jun 9, 2022
2 parents 0885283 + 7d8fab8 commit 1906079
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions demo/src/main/res/layout/fragment_image_viewer.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<com.google.android.material.appbar.AppBarLayout
android:id="@+id/app_bar"
android:layout_width="match_parent"
android:layout_height="56dp"
android:layout_height="wrap_content"
android:stateListAnimator="@null"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand All @@ -20,7 +20,7 @@
<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="match_parent" />
android:layout_height="wrap_content" />

</com.google.android.material.appbar.AppBarLayout>

Expand Down
4 changes: 2 additions & 2 deletions demo/src/main/res/layout/fragment_number_bottom_sheet.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
<com.google.android.material.appbar.AppBarLayout
android:id="@+id/app_bar"
android:layout_width="match_parent"
android:layout_height="56dp"
android:layout_height="wrap_content"
android:background="@color/transparent"
android:stateListAnimator="@null"
app:layout_constraintTop_toTopOf="parent">

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_height="wrap_content"
android:background="@color/transparent"/>

</com.google.android.material.appbar.AppBarLayout>
Expand Down
4 changes: 2 additions & 2 deletions demo/src/main/res/layout/fragment_numbers.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
<com.google.android.material.appbar.AppBarLayout
android:id="@+id/app_bar"
android:layout_width="match_parent"
android:layout_height="56dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent">

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="match_parent" />
android:layout_height="wrap_content" />

</com.google.android.material.appbar.AppBarLayout>

Expand Down
2 changes: 1 addition & 1 deletion demo/src/main/res/layout/fragment_web_home.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="match_parent" />
android:layout_height="wrap_content" />

<androidx.appcompat.widget.AppCompatImageView
android:id="@+id/app_bar_logo"
Expand Down
4 changes: 2 additions & 2 deletions turbo/src/main/res/layout/turbo_fragment_web.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
<com.google.android.material.appbar.AppBarLayout
android:id="@+id/app_bar"
android:layout_width="match_parent"
android:layout_height="56dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent">

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="match_parent" />
android:layout_height="wrap_content" />

</com.google.android.material.appbar.AppBarLayout>

Expand Down
4 changes: 2 additions & 2 deletions turbo/src/main/res/layout/turbo_fragment_web_bottom_sheet.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
<com.google.android.material.appbar.AppBarLayout
android:id="@+id/app_bar"
android:layout_width="match_parent"
android:layout_height="56dp"
android:layout_height="wrap_content"
android:background="@color/transparent"
android:stateListAnimator="@null">

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_height="wrap_content"
android:background="@color/transparent" />

</com.google.android.material.appbar.AppBarLayout>
Expand Down

0 comments on commit 1906079

Please sign in to comment.