Skip to content

Commit

Permalink
Merge pull request #119 from joemasilotti/ios-14-cleanup
Browse files Browse the repository at this point in the history
iOS 14 cleanup
  • Loading branch information
jayohms authored Aug 29, 2023
2 parents 312f369 + a6d6cd9 commit dd75c0e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Docs/Migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ Follow these steps, and you should be up and running in no time. I was able to u


## Changes from turbolinks-ios
1. Requires iOS 12 and later. Most likely we will also drop support for iOS 12 in the near future.
2. Fixed numerous scroll inset issues with the web view. Almost all of these culminated from underlying WebKit bug across versions iOS 10 and iOS 11. It seems they were all fixed in iOS 12, so that's why iOS 12 is now required. That means we could drop our hacks for getting the correct inset for the web view and rely on the iOS to do it automatically. The web view now sits full under the nav bar/tab bars and works as expected as far as scroll positioning and restoration
1. Requires iOS 14 and later.
2. Fixed numerous scroll inset issues with the web view. Almost all of these culminated from underlying WebKit bug across versions iOS 10 and iOS 11. It seems they were all fixed in iOS 12, so that's why iOS 12+ is now required. That means we could drop our hacks for getting the correct inset for the web view and rely on the iOS to do it automatically. The web view now sits full under the nav bar/tab bars and works as expected as far as scroll positioning and restoration


## Whats new in Turbo iOS?
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import PackageDescription
let package = Package(
name: "Turbo",
platforms: [
.iOS(.v13)
.iOS(.v14)
],
products: [
.library(
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

## Requirements

Turbo iOS is written in Swift 5.3 and requires iOS 12 or higher, but we'll most likely drop iOS 12 in the near future. It supports web apps using either Turbo 7 or Turbolinks 5. The Turbo iOS framework has no dependencies.
Turbo iOS is written in Swift 5.3 and requires iOS 14 or higher. It supports web apps using either Turbo 7 or Turbolinks 5. The Turbo iOS framework has no dependencies.

**Note:** You should understand how Turbo works with web applications in the browser before attempting to use Turbo iOS. See the [Turbo 7 documentation](https://github.com/hotwired/turbo) for details. Ensure that your web app sets the `window.Turbo` global variable as it's required by the native apps:

Expand Down
2 changes: 1 addition & 1 deletion Turbo.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Pod::Spec.new do |spec|
spec.homepage = "https://turbo.hotwired.dev/"
spec.license = { :type => "MIT", :file => "LICENSE" }
spec.author = { "Zach Waugh" => "zwaugh@gmail.com" }
spec.platform = :ios, "12.0"
spec.platform = :ios, "14.0"
spec.source = { :git => "https://github.com/hotwired/turbo-ios.git", :tag => spec.version }
spec.source_files = "Source/**/*.swift"
spec.resources = "Source/**/*.js"
Expand Down

0 comments on commit dd75c0e

Please sign in to comment.