Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #155 which assumed that Turbo Native was using the same algorithm as Turbo to set flash notices.
When a redirection with a responseHTML would happen (e.g. a form submission), Turbo Native receives something like the following:
This usually gets turned into a JavaScript visit and then handed over to the bridge, which begins the visit by calling
visitLocationWithOptionsAndRestorationIdentifier
.However, when transforming this proposal JS -> Swift (for processing) and back to JS (for bridge consumption),
visitProposed["options"]["response"]["redirected"]
was being lost. This causedresponseHTML
to be ignored and a replace visit to be proposed instead.By adding
redirected
toVisitResponse
the behavior is now correct.