When testing in parallel, ignore orphaned child pids.

[mvsjes2]

Addresses issue #113

When running prove without this fix, you get "Attempt to detach from wrong child" from Test2::Async while the test suite is running, and "Subtest can only be finished in the process/thread that created it" during destruction.

With this fix, we just get a new warning "Ignoring unknown child pid $pid, did a grandchild pid die?" and no other further complaints from Test2 or Test::Class::Moose.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.50%. Comparing base (f263d2e) to head (20f3a16).

Files	Patch %	Lines
lib/Test/Class/Moose/Executor/Parallel.pm	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   93.57%   93.50%   -0.08%     
==========================================
  Files          92       92              
  Lines        3006     3000       -6     
  Branches      142      143       +1     
==========================================
- Hits         2813     2805       -8     
- Misses        137      138       +1     
- Partials       56       57       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[autarch]

Thanks for working on this! Can you also add a test for this issue that fails without the changes in this PR?

[mvsjes2]

For sure, I'm working on it in my spare time. Having some trouble understanding the test framework.

…

On Sun, Apr 7, 2024, 12:36 a.m. Dave Rolsky ***@***.***> wrote: Thanks for working on this! Can you also add a test for this issue that fails without the changes in this PR? — Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYT3UOXCG5X6ECRIIISSYTY4C5NHAVCNFSM6AAAAABFSEN2D6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGI4TMNBUHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[autarch]

Yeah, unfortunately writing tests for test tools can be a bit confusing. It uses the intercept sub from https://metacpan.org/pod/Test2::API to capture all the test events generated when Test::Class::Moose runs.

Then it uses https://metacpan.org/pod/Test2::V0 to import a bunch of test helpers which are used to check the events. I think the easiest approach is to write some code that causes the bug, capture the events with intercept, dump them with something like Data::Dumper or DDP, then do the same with the bug fixed.

The "diff" between those two events is the thing you want to check for.

[mvsjes2]

OK, thanks for the insight. I do have a test 1/2 written for this, just not ready to push up yet. I have this PR in draft mode for now. Will switch it to ready once I think I have all the bits worked out.