Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8609 - fix tools in rooms #5416

Merged
merged 19 commits into from
Jan 8, 2025
Merged

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Jan 7, 2025

Description

Links to Tickets or other pull requests

BC-8609

Changes

when user interacts with a columnBoard which is part of a room:

  • if user is from the same school as the room:
    • none
  • if user is from a different school as the room:
    • external tools are displayed and can be interacted with
    • external tools can be listed and added (but only tools defined for that school)

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@hoeppner-dataport hoeppner-dataport merged commit 17aecd5 into main Jan 8, 2025
133 checks passed
@hoeppner-dataport hoeppner-dataport deleted the BC-8609-fix-tools-in-rooms branch January 8, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants