Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

544 configure meilisearch #561

Merged
merged 12 commits into from
Jun 20, 2023
Merged

544 configure meilisearch #561

merged 12 commits into from
Jun 20, 2023

Conversation

baerlach-git
Copy link
Collaborator

@baerlach-git baerlach-git commented Jun 16, 2023

The config should be mostly fine now, maybe some tweaking will be necessary in the future. The helper function can be used to test the search functionality, but it needs a running meilisearch instance to work. The installation is quick and easy, see: https://www.meilisearch.com/docs/learn/getting_started/installation . So far the search is not implemented in the site. I used a console.log() in the searchview to test the results so far and left it in the pr for the reviewers convenience.

@baerlach-git baerlach-git linked an issue Jun 16, 2023 that may be closed by this pull request
@baerlach-git baerlach-git requested a review from olschulz June 16, 2023 11:03
Copy link
Collaborator

@olschulz olschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@@ -34,6 +34,8 @@
"pg": "8.6.0",
"pm2": "^5.2.0",
"sendmail": "^1.6.1",
"sharp": "^0.32.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked this up and it seems to be related to image optimization. Do we do some sort of image search or why do we need this package?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i merged staging into my local branch and and suddenly got errors because the sharp package was missing, so installed it. I don't know where this dependency comes from

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, for me it works without the package

@baerlach-git baerlach-git merged commit a24e96e into staging Jun 20, 2023
@baerlach-git baerlach-git deleted the 544-configure-meilisearch branch June 20, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure Meilisearch
3 participants