Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes layout of Printbugger to resemble a flame graph #101

Merged
merged 6 commits into from
Dec 4, 2021
Merged

Changes layout of Printbugger to resemble a flame graph #101

merged 6 commits into from
Dec 4, 2021

Conversation

JoeAtHPI
Copy link
Collaborator

@JoeAtHPI JoeAtHPI commented Nov 20, 2021 •
edited
Loading

The lines in a BPSwimlane now correspond to all (filtered) called methods, creating a stack of method calls for a traced value.
This results in a proper flame graph.
image

Additionally, hover and click to the method interactions have been added.

Resulting issues from this PR: #102

@JoeAtHPI JoeAtHPI added enhancement New feature or request visual Only visual changes have been made probelog labels Nov 20, 2021
@JoeAtHPI JoeAtHPI self-assigned this Nov 20, 2021
@JoeAtHPI
Copy link
Collaborator Author

JoeAtHPI commented Nov 20, 2021 •
edited
Loading

Failing test passes locally... 😢

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1483384651

  • 92 of 92 (100.0%) changed or added relevant lines in 18 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 68.209%
Files with Coverage Reduction New Missed Lines %
packages/Babylonian-Core.package/BPTraceValue.class/instance/isStackFull.st 4 0%
packages/Babylonian-Printbugger.package/BPSwimlane.class/instance/colorFor.in..st 4 0%
Totals Coverage Status
Change from base Build 1467295955: -0.1%
Covered Lines: 5853
Relevant Lines: 8581
💛 - Coveralls

LinaUr
LinaUr approved these changes Nov 20, 2021
View reviewed changes
Copy link
Collaborator

@LinaUr LinaUr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the failing test, the changes look fine to me.

@JoeAtHPI JoeAtHPI merged commit e368016 into develop Dec 4, 2021
@JoeAtHPI JoeAtHPI deleted the feature/flameGraph branch October 18, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinaUr LinaUr LinaUr approved these changes

@codeZeilen codeZeilen codeZeilen approved these changes

Assignees

@JoeAtHPI JoeAtHPI

Labels
enhancement New feature or request probelog visual Only visual changes have been made
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoeAtHPI @coveralls @codeZeilen @LinaUr