Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Auto Refactoring for the BPBrowser #92

Merged
merged 21 commits into from
Nov 16, 2021

Conversation

JoeAtHPI
Copy link
Collaborator

@JoeAtHPI JoeAtHPI commented Oct 24, 2021

Since the BPBrowser breaks the premise of the Parser that the source stream and the code panel's morph code is the same, auto refactoring will quickly cause inconsistencies. For example, if one were to add a temporal variable to existing ones, with the second vertical line being at position 18, the styled version could have it at position 19. The parser would then re-add two lines, causing for synctactic errors when compiling. Therefore, this PR removes the text styling inside the morph to re-fullfill that premise again during compilation.

Sadly, in the new approach, as BPStyler is not thread safe, adding probes caused the browser to not delete the existing annotation morphs when switching its view. This caused for visual clutter.
image

The workaround forces a style update manually, but the future should include fixing this issue #93 .

@JoeAtHPI JoeAtHPI added bug Something isn't working enhancement New feature or request labels Oct 24, 2021
@JoeAtHPI JoeAtHPI requested a review from codeZeilen October 24, 2021 01:23
@JoeAtHPI JoeAtHPI self-assigned this Oct 24, 2021
@coveralls
Copy link

coveralls commented Oct 24, 2021

Copy link
Member

@codeZeilen codeZeilen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the tests! There are only two minor suggestions.

@JoeAtHPI
Copy link
Collaborator Author

@codeZeilen Any idea why the tests are failing remotely? It's like the ci doesn't recognize BPCompilerExceptionTest as a subclass of CompilerExceptionsTest :/

@codeZeilen
Copy link
Member

@JoeAtHPI Sorry the whole thing was my fault. 5.3 should not be activated on develop. We do not target 5.3 anymore! If you merge develop again into this PR and uncomment the tests we should be good to go.

@JoeAtHPI JoeAtHPI merged commit 2cd92f7 into develop Nov 16, 2021
@JoeAtHPI JoeAtHPI deleted the big/fix-auto-refactor-styling branch December 4, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants