-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Auto Refactoring for the BPBrowser #92
Conversation
trunk changes to branch
…ditor morphh text
update fix auto refactoring
packages/Babylonian-Tests.package/BPCompilerExceptionTest.class/instance/setUp.st
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the tests! There are only two minor suggestions.
packages/Babylonian-UI.package/BPStyler.class/instance/unstyledTextFrom..st
Show resolved
Hide resolved
@codeZeilen Any idea why the tests are failing remotely? It's like the ci doesn't recognize |
@JoeAtHPI Sorry the whole thing was my fault. 5.3 should not be activated on develop. We do not target 5.3 anymore! If you merge develop again into this PR and uncomment the tests we should be good to go. |
Since the BPBrowser breaks the premise of the Parser that the source stream and the code panel's morph code is the same, auto refactoring will quickly cause inconsistencies. For example, if one were to add a temporal variable to existing ones, with the second vertical line being at position 18, the styled version could have it at position 19. The parser would then re-add two lines, causing for synctactic errors when compiling. Therefore, this PR removes the text styling inside the morph to re-fullfill that premise again during compilation.
Sadly, in the new approach, as BPStyler is not thread safe, adding probes caused the browser to not delete the existing annotation morphs when switching its view. This caused for visual clutter.
The workaround forces a style update manually, but the future should include fixing this issue #93 .