fix annoucnements tests

hpi-swa-lab · Nov 19, 2024 · dfbef95 · dfbef95
1 parent d20ab9e
commit dfbef95
Show file tree

Hide file tree

Showing 7 changed files with 25 additions and 2 deletions.
diff --git a/...es/SqueakInboxTalk.package/TalkInboxBrowserAnnouncement.class/instance/includesAuthor..st b/...es/SqueakInboxTalk.package/TalkInboxBrowserAnnouncement.class/instance/includesAuthor..st
@@ -0,0 +1,4 @@
+accessing - conversation
+includesAuthor: aPerson
+
+	^ false
diff --git a/packages/SqueakInboxTalk.package/TalkInboxBrowserAnnouncement.class/methodProperties.json b/packages/SqueakInboxTalk.package/TalkInboxBrowserAnnouncement.class/methodProperties.json
@@ -18,6 +18,7 @@
 		"hasContributions" : "ct 11/18/2024 03:15",
 		"hide" : "ct 11/18/2024 20:46",
 		"inbox" : "ct 11/18/2024 03:41",
+		"includesAuthor:" : "ct 11/19/2024 01:11",
 		"involvementState" : "ct 11/18/2024 03:17",
 		"isTalkAnnouncement" : "ct 11/18/2024 03:32",
 		"latestDate" : "ct 11/18/2024 03:14",

diff --git a/...akInboxTalkTests.package/TalkInboxBrowser.extension/class/dontShowAnnouncementsDuring..st b/...akInboxTalkTests.package/TalkInboxBrowser.extension/class/dontShowAnnouncementsDuring..st
@@ -0,0 +1,9 @@
+*SqueakInboxTalkTests-preferences
+dontShowAnnouncementsDuring: aBlock
+
+	self shouldShowAnnouncements ifFalse: [^ aBlock value].
+
+	self shouldShowAnnouncements: false.
+	^ aBlock ensure:
+		[[self shouldShowAnnouncements: true]
+			valueSupplyingAnswer: #('reset all announcements' false)]
diff --git a/packages/SqueakInboxTalkTests.package/TalkInboxBrowser.extension/methodProperties.json b/packages/SqueakInboxTalkTests.package/TalkInboxBrowser.extension/methodProperties.json
@@ -0,0 +1,5 @@
+{
+	"class" : {
+		"dontShowAnnouncementsDuring:" : "ct 11/19/2024 01:18" },
+	"instance" : {
+		 } }
diff --git a/packages/SqueakInboxTalkTests.package/TalkInboxBrowser.extension/properties.json b/packages/SqueakInboxTalkTests.package/TalkInboxBrowser.extension/properties.json
@@ -0,0 +1,2 @@
+{
+	"name" : "TalkInboxBrowser" }
diff --git a/packages/SqueakInboxTalkTests.package/TalkInboxBrowserTest.class/instance/setUp.st b/packages/SqueakInboxTalkTests.package/TalkInboxBrowserTest.class/instance/setUp.st
@@ -5,4 +5,6 @@ setUp
 
 	browser := self classUnderTest on: TalkInboxTestResource current inbox.
 	TalkInboxTestResource current importCachesFor: self.
-	self waitWhileBusy
+	self waitWhileBusy.
+
+	self wrapTest: [:block | browser class dontShowAnnouncementsDuring: block].
diff --git a/packages/SqueakInboxTalkTests.package/TalkInboxBrowserTest.class/methodProperties.json b/packages/SqueakInboxTalkTests.package/TalkInboxBrowserTest.class/methodProperties.json
@@ -5,7 +5,7 @@
 		"classUnderTest" : "ct 5/20/2021 19:01",
 		"defaultTimeout" : "ct 7/21/2021 17:14",
 		"findFilterItem:" : "ct 7/7/2021 22:18",
-		"setUp" : "ct 7/23/2021 19:36",
+		"setUp" : "ct 11/19/2024 01:15",
 		"shouldBeFiltered" : "ct 7/7/2021 22:09",
 		"shouldBeFiltered:" : "ct 7/7/2021 22:11",
 		"shouldNotBeFiltered" : "ct 6/4/2023 00:44",