Implement a combination matrix type with support for read #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greole
force-pushed
the
impl/combination_matrix
branch
2 times, most recently
from
fbff730
to
40dafc1
Compare
greole
force-pushed
the
impl/combination_matrix
branch
from
40dafc1
to
b23fb49
Compare
greole
commented
Aug 8, 2024
to read matrix data from a file - Add matrix data for the unit test in Matrix Market Exchange Format (.mtx) - Modify the CMake configuration file for HostMatrix in order to copy matrix to the build directory of unit tests
- Enable reading the b vector data from the file - Modify the CMake file to copy vector data to the build directory
…inal matrix which consists of integers - Create a mtx file for storing a vector - Remove commented lines of code and reorganize the unit test
…rices - Add 3 mtx files for storing L, D, and U matrices, respectively - Modify the CMake file to copy L, D, and U matrices over to the build directory
the function convert_to COO format
- Add assertion tests for verifying row and column indices
- Add a unit test for the function
- Add a unit test for that function
- Add a unit test for that function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a version combination matrix which allows to perform SpMV of multiple submatrices Ie Ax = (B+C+ ...N)x, where A is the combination matrix and B to N are the submatrices. In principle, we could also use Ginkgos combination matrix, but ginkgos combination matrix lacks an implementation of
readwhich we to use the combination matrix as inner matrix type of the distributed matrixThis allows us several improvements in future PRs:
Todo
Requires: