Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is and as support for std::expected #954

Closed
wants to merge 0 commits into from

Conversation

bluetarpmedia
Copy link
Contributor

  • Update cpp2util.h to support is and as for std::expected
  • Add new pure2-expected-is-as regression test

@hsutter
Copy link
Owner

hsutter commented Jan 25, 2024

Thanks! @filipsajdak @bluetarpmedia Does this conflict with #701, which I think is close to ready to review again?

@filipsajdak
Copy link
Contributor

There is a conflict. I can prepare an update to it. But first I will split #701.

@bluetarpmedia
Copy link
Contributor Author

There is a conflict. I can prepare an update to it. But first I will split #701.

Thanks @filipsajdak -- I didn't mean to intrude on your work!

@filipsajdak
Copy link
Contributor

No intrusion. I like that you bring up the std::expected

@bluetarpmedia
Copy link
Contributor Author

I wasn't able to successfully rebase this onto the updated code in main, so I've closed this and created #971.

@JohelEGP
Copy link
Contributor

JohelEGP commented Feb 7, 2024

You can always take the local branch that you updated
and do git checkout this_branch, git reset --hard that_branch, and git push -f
to avoid closing and reopening a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants