Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding global vars to pass cR CMD check #22

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Adding global vars to pass cR CMD check #22

merged 2 commits into from
Mar 20, 2024

Conversation

matthew-phelps
Copy link
Contributor

No description provided.

@matthew-phelps matthew-phelps marked this pull request as ready for review March 20, 2024 08:02
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 94.17476% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.89%. Comparing base (21074d1) to head (55a8f8c).

Files Patch % Lines
R/evaluate_criteria.R 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #22      +/-   ##
==========================================
+ Coverage   88.24%   89.89%   +1.64%     
==========================================
  Files          27       25       -2     
  Lines        1217     1297      +80     
==========================================
+ Hits         1074     1166      +92     
+ Misses        143      131      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthew-phelps matthew-phelps merged commit fba4afb into dev Mar 20, 2024
9 checks passed
@matthew-phelps matthew-phelps deleted the pass_check branch March 20, 2024 12:56
nsjohnsen pushed a commit that referenced this pull request Mar 25, 2024
* Doc_cleanup (#21)

* Move dev related texted out of main page and into dev page

* Deleting articles that live in ramnog

* Removing documentation that was moved to ramnog package

* Apply stylr to whole package

* Update README

* Adding global vars to pass cR CMD check (#22)

* Adding global vars to pass R CMD check

* Fix merge conflicts

* Centralize pre-commit and git-action to hta-pharma/ramnog

* Consume workflows from ramnog@main instead of dev branch

* Added reference to ramnog

* Rename so that it matches workflows

* Remove un-used argument in use_chef

---------

Co-authored-by: Henrik Sparre Spiegelhauer (HSPU) <hspu@novonordisk.com>
matthew-phelps added a commit that referenced this pull request Mar 26, 2024
* Doc_cleanup (#21)

* Move dev related texted out of main page and into dev page

* Deleting articles that live in ramnog

* Removing documentation that was moved to ramnog package

* Apply stylr to whole package

* Update README

* Adding global vars to pass cR CMD check (#22)

* Centralize pre-commit and git-action to hta-pharma/ramnog (#23)

* Centralize pre-commit and git-action to hta-pharma/ramnog

* Consume workflows from ramnog@main instead of dev branch


---------

Co-authored-by: Henrik Sparre Spiegelhauer (HSPU) <hspu@novonordisk.com>
Co-authored-by: Matthew Phelps <mewp@novonordisk.com>

---------

Co-authored-by: Matthew Phelps <ma.phelps@gmail.com>
Co-authored-by: Henrik Sparre Spiegelhauer (HSPU) <hspu@novonordisk.com>
Co-authored-by: Matthew Phelps <mewp@novonordisk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants