Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export maic_unanchored_tte etc? #102

Open
gravesti opened this issue May 21, 2024 · 2 comments
Open

Export maic_unanchored_tte etc? #102

gravesti opened this issue May 21, 2024 · 2 comments

Comments

@gravesti
Copy link
Contributor

          if this is not exported, this wrapper becomes a blackbox.

How do users know what is done behind the scenes. Only way is to download the whole package and dig into the code.

Originally posted by @MikeJSeo in #93 (comment)

@hoppanda
Copy link
Member

team discussed and decided to export, mark as internal function, documentation need to be clear and state that these functions could be changed in a future version

@MikeJSeo
Copy link
Collaborator

team discussed again and decided not to export. Instead, maybe adding some descriptions the the wrapper function what it does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants