Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

80 add binary to wrapper function for unanchored case #93

Merged
merged 31 commits into from
May 23, 2024
Merged

80 add binary to wrapper function for unanchored case #93

merged 31 commits into from
May 23, 2024

Conversation

hoppanda
Copy link
Member

@hoppanda hoppanda commented May 3, 2024

No description provided.

hoppanda and others added 18 commits March 15, 2024 08:02
@hoppanda
add binary-helper.R
01cbf8b
@hoppanda
tempo update
f42919c
@hoppanda
update
b57bcd3
@hoppanda
reformat as anchored wrapper function and add in binary initial script
6c01591
@hoppanda
separate binary inferential part to a separate function
e0bcd19
@hoppanda
refine binary inferential function
4053945
@hoppanda
Merge pull request #91 from hta-pharma/67-add-function-to-expand-2x2-…
dc73d8f 
…table

67 add function to expand 2x2 table
@hoppanda
workable binary unanchor
d2ce708
@hoppanda
add unanchored binary example
818cc53
@hoppanda
keep consistency of treatment column name between binary and tte usin…
0135d0f 
…g report_table function
@hoppanda
make binary bootstrap work with cli progress bar
cd699ff
@hoppanda
styler
467327c
@hoppanda
update unanchor binary example annotation
45cbd9a
@hoppanda
add test for binary helper function
211f6d9
@hoppanda
add test for binary unanchored MAIC wrapper
931d83e
@hoppanda
add boot quantile function, and test for tte unanchor maic wrapper
433ebb8
@hoppanda
update document
095f857
@hoppanda
deactive unnecessary line in testthat
04bd382
@hoppanda hoppanda linked an issue May 3, 2024 that may be closed by this pull request
add binary to wrapper function for unanchored case #80
Closed
@hoppanda hoppanda requested review from gravesti and MikeJSeo May 3, 2024 05:58
MikeJSeo
MikeJSeo requested changes May 13, 2024
View reviewed changes
man/get_pseudo_ipd_binary.Rd Outdated Show resolved Hide resolved
man/get_pseudo_ipd_binary.Rd Outdated Show resolved Hide resolved
inst/examples/maic_unanchored_ex.R Show resolved Hide resolved
inst/examples/maic_unanchored_ex.R Outdated Show resolved Hide resolved
inst/examples/maic_unanchored_binary_ex.R Outdated Show resolved Hide resolved
R/maic_unanchored.R Show resolved Hide resolved
R/maic_unanchored.R Outdated Show resolved Hide resolved
R/maic_unanchored.R Outdated Show resolved Hide resolved
R/maic_unanchored.R Outdated Show resolved Hide resolved
R/maic_unanchored.R Outdated Show resolved Hide resolved
@MikeJSeo
Copy link
Collaborator

MikeJSeo commented May 13, 2024 •
edited
Loading

image why is some comments hidden? Please look at these too. Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------
R/binary-helper.R         59       7  88.14%   14, 18, 21, 24, 28, 31, 36
R/bootstrap.R             23      23  0.00%    54-88
R/bucher.R                50       4  92.00%   49, 97, 101, 105
R/data_generation.R       20      20  0.00%    36-73
R/maic_anchored.R        140      32  77.14%   62-69, 74-77, 81, 84, 88, 91-94, 97-100, 105-106, 110, 113, 134-139, 156
R/maic_unanchored.R      251      40  84.06%   79-86, 89-90, 95, 98-101, 104-107, 112, 122, 125, 147-154, 183, 276-277, 344-348, 376-377, 409-410
R/matching.R             238     142  40.34%   60, 67, 72-75, 82-89, 110, 167, 200, 242-502
R/plot_km.R              439     439  0.00%    46-736
R/plot_km2.R             107     107  0.00%    50-209
R/process_data.R         101      44  56.44%   49-51, 56, 71-74, 80, 92-93, 183, 216-280
R/reporting.R             59       1  98.31%   91
R/survival-helper.R       30       3  90.00%   63, 66-67
R/time-helper.R            9       4  55.56%   22, 37-38, 52
R/zzz.R                    1       1  0.00%    2
TOTAL                   1527     867  43.22%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  -------
R/binary-helper.R        +59      +7  +88.14%
R/maic_unanchored.R     +125     -86  +84.06%
R/reporting.R            +40      +1  -1.69%
TOTAL                   +224     -78  +15.75%

Results for commit: 342292f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@gravesti
style
92cabbd
@gravesti
Merge branch '80-add-binary-to-wrapper-function-for-unanchored-case' …
32efd83 
…of github.com:hta-pharma/maicplus into 80-add-binary-to-wrapper-function-for-unanchored-case
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
get_pseudo_ipd_binary 👶 $+0.02$ $+2$ $0$ $0$ $0$
maic_unanchored 👶 $+3.31$ $+8$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
get_pseudo_ipd_binary 👶 $+0.00$ generate_pseudo_binary_IPD_given_stacked_table_as_input
get_pseudo_ipd_binary 👶 $+0.02$ generate_pseudo_binary_IPD_given_unstacked_table_as_input
maic_unanchored 👶 $+0.32$ test_binary_case
maic_unanchored 👶 $+2.99$ test_time_to_event_case

Results for commit 67b5284

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

Unit Tests Summary

 1 files   5 suites   4s ⏱️
15 tests 15 ✅ 0 💤 0 ❌
47 runs  47 ✅ 0 💤 0 ❌

Results for commit a9f5060.

♻️ This comment has been updated with latest results.

This was referenced May 21, 2024
Open
Open
@gravesti gravesti requested a review from MikeJSeo May 22, 2024 16:51
@gravesti gravesti merged commit 17eb848 into main May 23, 2024
@gravesti gravesti deleted the 80-add-binary-to-wrapper-function-for-unanchored-case branch May 23, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeJSeo MikeJSeo MikeJSeo approved these changes

@gravesti gravesti gravesti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
maicplus-v010
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add binary to wrapper function for unanchored case
3 participants
@hoppanda @MikeJSeo @gravesti