New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider rounding in outputs and reporting tables #101

Open

4 tasks

gravesti opened this issue May 21, 2024 · 1 comment · May be fixed by #139

Assignees

Labels

Contributor

gravesti commented May 21, 2024 •

edited

Loading

Consider R/maic_unanchored.R around #422
eg tmp_report_table_binary <- paste0(format(round(..., 2), nsmall = 2)

          Digits is fixed to 2. If user wants 3 digits, there's no way to retrieve it.

Can you return the original calculated confidence interval/standard error
i.e. boot_res_AB and res_AB

Originally posted by @MikeJSeo in #93 (comment)

review "raw" calculated values, including CI and p-values, tests
classes for list of wrapper function output = "raw" values
print methods for nice printing of raw values
summary methods for rounding and formatting for reports

The text was updated successfully, but these errors were encountered:

gravesti mentioned this issue

80 add binary to wrapper function for unanchored case #93

Merged

gravesti added the this version label

Contributor Author

gravesti commented Jun 28, 2024

@hoppanda @MikeJSeo
To review raw format and printed/summary format:

estimate, sd, var, ci upper, ci lower
remove p-values in bootstrap?
- Only report p-values where they are correct, consistent and meaningful!
- Describe which test the p-value comes from

gravesti assigned gravesti and hoppanda and unassigned gravesti

hoppanda linked a pull request

that will close this issue

101 reconsider rounding in outputs and reporting tables #139

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment