Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

101 reconsider rounding in outputs and reporting tables #139

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

101 reconsider rounding in outputs and reporting tables #139

wants to merge 30 commits into from
+459 −181

Conversation

hoppanda
Copy link
Member

@hoppanda hoppanda commented Sep 3, 2024

No description provided.

@hoppanda hoppanda linked an issue Sep 3, 2024 that may be closed by this pull request
Reconsider rounding in outputs and reporting tables #101
Open
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
matching 💀 $0.02$ $-0.02$ estimate_weights_works_as_expected_with_alternative_bootstrap_strata

Results for commit 30db737

♻️ This comment has been updated with latest results.

gravesti
gravesti reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

Add extra element to results data containing the combined data that is used for model fitting

R/binary-helper.R Outdated Show resolved Hide resolved
R/binary-helper.R Outdated Show resolved Hide resolved
R/binary-helper.R Outdated Show resolved Hide resolved
R/bucher.R Show resolved Hide resolved
R/maic_anchored.R Show resolved Hide resolved
R/maic_unanchored.R Outdated Show resolved Hide resolved
MikeJSeo
MikeJSeo reviewed Sep 9, 2024
View reviewed changes
R/maic_unanchored.R Outdated Show resolved Hide resolved
MikeJSeo

This comment was marked as resolved.

Sign in to view

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Unit Tests Summary

 1 files   9 suites   6s ⏱️
29 tests 22 ✅ 1 💤  5 ❌ 1 🔥
89 runs  61 ✅ 8 💤 19 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit 5f16834.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeJSeo MikeJSeo MikeJSeo left review comments

@gravesti gravesti gravesti left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
maicplus-v010
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconsider rounding in outputs and reporting tables
3 participants
@hoppanda @MikeJSeo @gravesti