Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev #118

Merged
merged 9 commits into from
Jul 12, 2024
Merged

rev #118

merged 9 commits into from
Jul 12, 2024

Conversation

MikeJSeo
Copy link
Collaborator

No description provided.

@MikeJSeo MikeJSeo requested a review from gravesti July 12, 2024 08:42
@MikeJSeo MikeJSeo linked an issue Jul 12, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jul 12, 2024

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  -----------------------------------------------------------------------------------
R/binary-helper.R         59       7  88.14%   14, 18, 21, 24, 28, 31, 36
R/bootstrap.R             23      23  0.00%    54-88
R/bucher.R                55       3  94.55%   103, 107, 111
R/data_generation.R       20      20  0.00%    36-73
R/maic_anchored.R        177      34  80.79%   65-72, 77-80, 84, 87, 91, 94-97, 100-103, 108-109, 113, 116, 138-143, 163, 223, 229
R/maic_unanchored.R      253      33  86.96%   77-84, 87-88, 93, 96-99, 102-105, 110, 120, 123, 146-153, 182, 239, 246, 355, 362
R/matching.R             245     146  40.41%   65, 70-72, 77-80, 87-94, 139, 175, 214, 256-516
R/plot_km.R              449     373  16.93%   46-598
R/plot_km2.R             107     107  0.00%    50-209
R/process_data.R         101      44  56.44%   49-51, 56, 71-74, 80, 92-93, 183, 216-280
R/reporting.R             59       1  98.31%   91
R/survival-helper.R       30       3  90.00%   63, 66-67
R/time-helper.R            9       4  55.56%   22, 37-38, 52
R/utils.R                 12      10  16.67%   4, 11-20
R/zzz.R                    1       1  0.00%    2
TOTAL                   1600     809  49.44%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: bcdf3ac

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@gravesti
Copy link
Contributor

@MikeJSeo Can you update the code in data-raw/dummy-anchored.R? And add an entry in R/data.R?

@MikeJSeo
Copy link
Collaborator Author

Hey @gravesti
I put in 1000 bootstrap iterations in weighted_twt. Is that okay?
Any more changes I need to do?

R/data.R Show resolved Hide resolved
data-raw/dummy_anchored.R Outdated Show resolved Hide resolved
R/data.R Outdated Show resolved Hide resolved
MikeJSeo and others added 4 commits July 12, 2024 15:27
Copy link
Contributor

Unit Tests Summary

 1 files   7 suites   4s ⏱️
21 tests 21 ✅ 0 💤 0 ❌
67 runs  67 ✅ 0 💤 0 ❌

Results for commit bcdf3ac.

Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @MikeJSeo !

@gravesti gravesti merged commit 24e4a02 into main Jul 12, 2024
24 checks passed
@gravesti gravesti deleted the 116-add-in-weighted_twt branch July 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add in weighted_twt
2 participants