Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

120 ordering of ggplot kmplot2 seems wrong #121

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

MikeJSeo
Copy link
Collaborator

No description provided.

@MikeJSeo MikeJSeo linked an issue Jul 12, 2024 that may be closed by this pull request
@MikeJSeo MikeJSeo requested a review from gravesti July 12, 2024 16:11
Copy link
Contributor

github-actions bot commented Jul 12, 2024

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  -----------------------------------------------------------------------------------
R/binary-helper.R         59       7  88.14%   14, 18, 21, 24, 28, 31, 36
R/bootstrap.R             23      23  0.00%    54-88
R/bucher.R                55       3  94.55%   103, 107, 111
R/data_generation.R       20      20  0.00%    36-73
R/maic_anchored.R        177      34  80.79%   65-72, 77-80, 84, 87, 91, 94-97, 100-103, 108-109, 113, 116, 138-143, 163, 223, 229
R/maic_unanchored.R      253      33  86.96%   77-84, 87-88, 93, 96-99, 102-105, 110, 120, 123, 146-153, 182, 239, 246, 355, 362
R/matching.R             245     146  40.41%   65, 70-72, 77-80, 87-94, 139, 175, 214, 256-516
R/plot_km.R              449     373  16.93%   46-598
R/plot_km2.R             107      22  79.44%   50, 59, 62, 65, 87-93, 120-128, 131, 175
R/process_data.R         101      44  56.44%   49-51, 56, 71-74, 80, 92-93, 183, 216-280
R/reporting.R             59       1  98.31%   91
R/survival-helper.R       30       3  90.00%   63, 66-67
R/time-helper.R            9       4  55.56%   22, 37-38, 52
R/utils.R                 12      10  16.67%   4, 11-20
R/zzz.R                    1       1  0.00%    2
TOTAL                   1600     724  54.75%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/plot_km2.R        0     -85  +79.44%
TOTAL               0     -85  +5.31%

Results for commit: c9a16f9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jul 12, 2024

Unit Tests Summary

 1 files   7 suites   6s ⏱️
22 tests 21 ✅ 1 💤 0 ❌
71 runs  68 ✅ 3 💤 0 ❌

Results for commit c9a16f9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeJSeo !

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_km 💔 $0.07$ $+1.81$ $+4$ $+3$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
plot_km 👶 $+1.75$ kmplot2_works

Results for commit 1bf855e

♻️ This comment has been updated with latest results.

@gravesti gravesti merged commit 88f7c55 into main Jul 18, 2024
25 checks passed
@gravesti gravesti deleted the 120-ordering-of-ggplot-kmplot2-seems-wrong branch July 18, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ordering of ggplot kmplot2 seems wrong
2 participants