-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify estimate_weight function #129
Conversation
Code Coverage Summary
Diff against main
Results for commit: 7a8a82b Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions :)
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
Unit Tests Summary 1 files 9 suites 6s ⏱️ Results for commit 7a8a82b. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 888b1f9 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hoppanda
I think we need just need a test for this new functionality
….com:hta-pharma/maicplus into 126-allow-user-specified-strata-in-bootstrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hoppanda
No description provided.