Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify estimate_weight function #129

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

hoppanda
Copy link
Member

No description provided.

@hoppanda hoppanda linked an issue Jul 26, 2024 that may be closed by this pull request
3 tasks
@hoppanda hoppanda requested a review from gravesti July 26, 2024 06:49
Copy link
Contributor

github-actions bot commented Jul 26, 2024

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------
R/binary-helper.R         59       7  88.14%   14, 18, 21, 24, 28, 31, 36
R/bucher.R                62       5  91.94%   103, 107, 111, 186-187
R/maic_anchored.R        348      46  86.78%   90-97, 102-105, 109, 112, 116, 119-122, 125-128, 133, 138, 141, 159-164, 215, 276, 282, 427-436, 445, 451, 522, 539
R/maic_unanchored.R      253      33  86.96%   82-89, 92-93, 98, 101-104, 107-110, 115, 124, 127, 150-157, 186, 243, 250, 359, 366
R/matching.R             251     146  41.83%   68, 73-75, 80-83, 90-93, 104, 131, 152, 188, 227, 269-530
R/plot_km.R              447      46  89.71%   53, 56, 59, 73-103, 294, 297-299, 314-317, 349, 405, 485, 488, 491, 503-504
R/plot_km2.R             107      22  79.44%   50, 59, 62, 65, 87-93, 120-128, 131, 176
R/process_data.R         101      55  45.54%   38-40, 45, 60-63, 69, 81-82, 113-124, 162, 195-260
R/reporting.R             59       0  100.00%
R/survival-helper.R       30       1  96.67%   61
R/time-helper.R           20       3  85.00%   31, 57-58
R/utils.R                 12       9  25.00%   11-20
R/zzz.R                    1       1  0.00%    2
TOTAL                   1750     374  78.63%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/matching.R       +7      +1  +1.26%
TOTAL              +7      +1  +0.03%

Results for commit: 7a8a82b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions :)

R/matching.R Outdated Show resolved Hide resolved
R/matching.R Outdated Show resolved Hide resolved
hoppanda and others added 2 commits August 11, 2024 21:48
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Aug 11, 2024

Unit Tests Summary

  1 files   9 suites   6s ⏱️
 30 tests 29 ✅ 1 💤 0 ❌
100 runs  92 ✅ 8 💤 0 ❌

Results for commit 7a8a82b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 11, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
matching 👶 $+0.02$ estimate_weights_works_as_expected_with_alternative_bootstrap_strata

Results for commit 888b1f9

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoppanda
I think we need just need a test for this new functionality

@gravesti gravesti self-requested a review August 15, 2024 11:37
Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoppanda

@gravesti gravesti merged commit c793780 into main Aug 15, 2024
24 checks passed
@gravesti gravesti deleted the 126-allow-user-specified-strata-in-bootstrap branch August 15, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

allow user specified strata in bootstrap
2 participants