-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some minor changes + R package dependency #33
Conversation
Code Coverage Summary
Diff against main
Results for commit: 9b84fe5 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MikeJSeo! A few little things that got missed.
I suggest we put the package description in DESCRIPTION.
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
…ma/maicplus into 32-minor-detail-changes
Can you merge this now? :) @gravesti |
I will review again tomorrow. You can also click the little refresh icon in
the pull request to request another review
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MikeJSeo! Looks much better and the checks are passing now :)
Can you just commit the one suggestion before merging?
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
Thanks Issac!! It looks like even with your approval, merging is not possible though. @gravesti |
Also changed description file and added maicplus.R.
Did I do something wrong here with the dependencies? ggplot2 in suggests and boot in import