Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some minor changes + R package dependency #33

Merged
merged 18 commits into from
Aug 15, 2023
Merged

Conversation

MikeJSeo
Copy link
Collaborator

Also changed description file and added maicplus.R.

Did I do something wrong here with the dependencies? ggplot2 in suggests and boot in import

@MikeJSeo MikeJSeo linked an issue Aug 11, 2023 that may be closed by this pull request
@MikeJSeo MikeJSeo closed this Aug 11, 2023
@MikeJSeo MikeJSeo reopened this Aug 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ---------
R/bucher.R                    22       9  59.09%   37, 63-72
R/data_generation.R           20      20  0.00%    36-73
R/maic_unanchored_tte.R       85      85  0.00%    25-164
R/matching.R                 133     133  0.00%    31-311
R/process_data.R             101     101  0.00%    39-261
R/survival-helper.R          139     139  0.00%    12-245
TOTAL                        500     487  2.60%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 9b84fe5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

R/maicplus.R Outdated Show resolved Hide resolved
Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeJSeo! A few little things that got missed.
I suggest we put the package description in DESCRIPTION.

R/maicplus.R Outdated Show resolved Hide resolved
R/bucher.R Show resolved Hide resolved
R/maic_unanchored_tte.R Show resolved Hide resolved
R/matching.R Show resolved Hide resolved
R/matching.R Outdated Show resolved Hide resolved
R/maicplus.R Outdated Show resolved Hide resolved
R/matching.R Outdated Show resolved Hide resolved
MikeJSeo and others added 5 commits August 14, 2023 12:44
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
@MikeJSeo MikeJSeo requested a review from gravesti August 14, 2023 12:01
@MikeJSeo
Copy link
Collaborator Author

MikeJSeo commented Aug 14, 2023

Can you merge this now? :) @gravesti

@gravesti
Copy link
Contributor

gravesti commented Aug 14, 2023 via email

Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeJSeo! Looks much better and the checks are passing now :)

Can you just commit the one suggestion before merging?

DESCRIPTION Outdated Show resolved Hide resolved
MikeJSeo and others added 2 commits August 15, 2023 09:38
Co-authored-by: Isaac Gravestock <83659704+gravesti@users.noreply.github.com>
@MikeJSeo
Copy link
Collaborator Author

Thanks Issac!! It looks like even with your approval, merging is not possible though. @gravesti
image

@gravesti gravesti merged commit 4fff987 into main Aug 15, 2023
@gravesti gravesti deleted the 32-minor-detail-changes branch August 15, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Minor detail changes
2 participants