Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rev #36

Merged
merged 17 commits into from
Aug 21, 2023
Merged

rev #36

merged 17 commits into from
Aug 21, 2023

Conversation

MikeJSeo
Copy link
Collaborator

Here's an attempt..
@gravesti @miranta-antoniou-roche

@MikeJSeo MikeJSeo linked an issue Aug 15, 2023 that may be closed by this pull request
add generic plot method for weights #25
Closed
3 tasks
@MikeJSeo MikeJSeo closed this Aug 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename                   Stmts    Miss  Cover    Missing
-----------------------  -------  ------  -------  ---------
R/bucher.R                    22       9  59.09%   37, 63-72
R/data_generation.R           20      20  0.00%    36-73
R/maic_unanchored_tte.R       85      85  0.00%    25-164
R/matching.R                 195     191  2.05%    31-449
R/process_data.R             101     101  0.00%    39-261
R/survival-helper.R          139     139  0.00%    12-245
TOTAL                        562     545  3.02%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/matching.R      +58     +58  -0.87%
TOTAL             +58     +58  -0.35%

Results for commit: 8380c01

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@MikeJSeo MikeJSeo reopened this Aug 15, 2023
@MikeJSeo MikeJSeo closed this Aug 15, 2023
@MikeJSeo MikeJSeo reopened this Aug 15, 2023
gravesti
gravesti reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeJSeo
I've made some suggestions. See if you can integrate the footnote text function we just merged :)

R/matching.R Outdated Show resolved Hide resolved
R/matching.R Outdated Show resolved Hide resolved
R/matching.R Outdated Show resolved Hide resolved
R/matching.R Outdated Show resolved Hide resolved
R/matching.R Show resolved Hide resolved
@gravesti gravesti mentioned this pull request Aug 16, 2023
Closed
@MikeJSeo
Copy link
Collaborator Author

Hi guys, made some modifications!
@gravesti @miranta-antoniou-roche

gravesti
gravesti reviewed Aug 18, 2023
View reviewed changes
R/matching.R Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Unit Tests Summary

2 tests   2 ✔️  0s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit 625ac9d.

gravesti
gravesti approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeJSeo I think we can merge this now :)

@gravesti gravesti merged commit 0ebb4c2 into main Aug 21, 2023
20 of 22 checks passed
@gravesti gravesti deleted the 25-add-generic-plot-method-for-weights branch August 21, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesti gravesti gravesti approved these changes

@hoppanda hoppanda Awaiting requested review from hoppanda

@ckalyvas ckalyvas Awaiting requested review from ckalyvas

@miranta-antoniou-roche miranta-antoniou-roche Awaiting requested review from miranta-antoniou-roche

Assignees
No one assigned
Labels
None yet
Projects
maicplus-v010
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add generic plot method for weights
2 participants
@MikeJSeo @gravesti