Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overview of ispor branch #65

Merged
merged 39 commits into from
Jan 24, 2024
Merged

overview of ispor branch #65

merged 39 commits into from
Jan 24, 2024

Conversation

gravesti
Copy link
Contributor

No description provided.

Copy link
Collaborator

@MikeJSeo MikeJSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just briefly reviewed kmplot function parameters.

inst/examples/kmplot_unanchored_ex.R Show resolved Hide resolved
inst/examples/kmplot_unanchored_ex.R Outdated Show resolved Hide resolved
inst/examples/kmplot_unanchored_ex.R Outdated Show resolved Hide resolved
@gravesti gravesti marked this pull request as ready for review January 19, 2024 08:33
Copy link
Contributor

github-actions bot commented Jan 19, 2024

badge

Code Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  --------------------
R/bootstrap.R             23      23  0.00%    54-88
R/bucher.R                22       9  59.09%   37, 63-72
R/data_generation.R       20      20  0.00%    36-73
R/maic_anchored.R        106     106  0.00%    52-202
R/maic_unanchored.R       95      95  0.00%    51-191
R/matching.R             203     181  10.84%   43-110, 130, 172-432
R/plot_km.R              439     439  0.00%    46-736
R/process_data.R         101     101  0.00%    39-280
R/reporting.R             19      19  0.00%    14-37
R/survival-helper.R       30      30  0.00%    26-82
R/time-helper.R            9       9  0.00%    22-54
R/zzz.R                    1       1  0.00%    2
TOTAL                   1068    1033  3.28%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/bootstrap.R            +23     +23  +100.00%
R/maic_anchored.R       +106    +106  +100.00%
R/maic_unanchored.R      +95     +95  +100.00%
R/matching.R              +8     -10  +8.79%
R/plot_km.R             +439    +439  +100.00%
R/reporting.R            +19     +19  +100.00%
R/survival-helper.R     -109    -109  +100.00%
R/time-helper.R           +9      +9  +100.00%
R/zzz.R                   +1      +1  +100.00%
TOTAL                   +591    +573  +0.25%

Results for commit: f055ded

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
matching 👶 $+0.01$ calculate_weights_legend_works

Results for commit ea8bd4c

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Unit Tests Summary

3 tests   3 ✅  0s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit f055ded.

♻️ This comment has been updated with latest results.

@gravesti
Copy link
Contributor Author

@MikeJSeo @hoppanda This looks ready to merge. The only thing left are some style issues but let's look at those later. Can you please give approval to merge?

@gravesti gravesti dismissed MikeJSeo’s stale review January 23, 2024 08:46

resolved as discussed

@gravesti
Copy link
Contributor Author

@MikeJSeo @hoppanda All the tests are passing now. Can one of you approve this pull request?

@gravesti gravesti merged commit df69e82 into main Jan 24, 2024
24 checks passed
@gravesti gravesti deleted the ispor-eu branch January 24, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants