Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/build_fixes #4

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Feature/build_fixes #4

merged 10 commits into from
Mar 18, 2024

Conversation

matthew-phelps
Copy link
Contributor

  • Fix failing unit tests after updates to chef
  • Add local function definition for unit-test instead of relying on dummy exported package function (mk_adae)
  • Minor updates to vignettes

@nsjohnsen
Copy link
Contributor

Need to handle merge conflict in DESCRIPTION before approval

@matthew-phelps matthew-phelps marked this pull request as ready for review March 18, 2024 09:30
@matthew-phelps matthew-phelps merged commit 43dffa9 into dev Mar 18, 2024
7 of 8 checks passed
@matthew-phelps matthew-phelps deleted the feature/build_fixes branch March 18, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsjohnsen nsjohnsen nsjohnsen approved these changes

Assignees

@nsjohnsen nsjohnsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew-phelps @nsjohnsen