Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anomaly likelihood #541

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Conversation

Zbysekz
Copy link

@Zbysekz Zbysekz commented Jul 5, 2019

#525 was closed prematurely. This is the final addition solving #517 completely. Tested on 1000x different seeds and everything passes.
There are thresholds adjusted and nullDistribution is added with mean parameter.

Fixes #517

Copy link
Member

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Zbysekz ! This looks good 👍

PS: seems you're working with Likelihood now, would you like looking at #469 ?

py/htm/algorithms/anomaly_likelihood.py Show resolved Hide resolved
Copy link
Author

@Zbysekz Zbysekz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@breznak can you approve if you agree with comment above ? Thanks. I'll see if i will have time for #469

py/htm/algorithms/anomaly_likelihood.py Show resolved Hide resolved
@breznak breznak merged commit 2bfb8c8 into htm-community:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EstimateAnomalyLikelihoods sometimes fail (unstable)
3 participants