TM anomaly: new modes: likelihood,... #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANMODE {DISABLED, RAW, LIKELIHOOD, LOGLIKELIHOOD}
struct anomaly_tm needed be known before the TM.anomaly& is used. Surprisingly this compiled well, but resulted in segfault
5 tasks
|
Ping.. |
ctrl-z-9000-times
approved these changes
Aug 10, 2019
| /* | ||
| * anomaly score computed for the current inputs | ||
| * (auto-updates after each call to TM::compute()) | ||
| * | ||
| * @return a float value from computeRawAnomalyScore() | ||
| * from Anomaly.hpp | ||
| */ | ||
| const Real &anomaly = anomaly_; | ||
| const Real &anomaly = tmAnomaly_.anomaly_; //this is position dependant, the struct anomaly_tm must be defined before this use, | ||
| // otherwise this surprisingly compiles, but a call to `tmAnomaly_.anomaly` segfaults! |
There was a problem hiding this comment.
wow, Interesting ...
This seems like a problem with the C++ language, or maybe the compiler? Thanks for making note of this issue.
There was a problem hiding this comment.
yep, strange thing, kept me busy for a while. The compiler might be, I've been using g++-9 recently due to the ParallelTS.
|
Thank you for reviews, I'll now be able to use this code in our NAB detector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #469 , and htm-community/NAB#5
TM.anomalyANMode {DISABLED, RAW, LIKELIHOOD, LOGLIKELIHOOD}and aims to replace code in NAB HTMcore detector