Больше деталей #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
SeraphimEvil
reviewed
Oct 7, 2024
| @@ -235,5 +235,6 @@ <h2 class="data-error__title">Не удалось загрузить данны | |||
| </template> | |||
|
|
|||
| <script src="/js/functions.js"></script> | |||
| <script src="/js/main.js"></script> | |||
There was a problem hiding this comment.
путь от корня, проверяй публикованную версию, текущий путь не будет работать
./js/main.js
| }; | ||
| }; | ||
|
|
||
| const createPhoto = () => { |
There was a problem hiding this comment.
возвращай сразу объект
There was a problem hiding this comment.
тк это метод массива у нас тут есть аргумент второй - индекс
его используй вместо id
There was a problem hiding this comment.
(_, index)
и этот index
| }; | ||
| }; | ||
|
|
||
| const photoList = Array.from({length: PHOTO_LIST_LENGTH}, createPhoto()); |
There was a problem hiding this comment.
тут колбек, скобки кажется лишние у createPhoto
и без них должно сработать, попробуй
| }; | ||
| }; | ||
|
|
||
| const createComment = () => { |
There was a problem hiding this comment.
также возвращаем сразу объект
также используем индекс
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Больше деталей
💥 https://htmlacademy-javascript.github.io/2357681-kekstagram-2/4/