fix: меняет сортировку на количество комментариев вместо лайков, доба…

…вляет переменную с классом активного фильтра
htmlacademy-javascript · Dec 15, 2024 · 48794c4 · 48794c4
1 parent 61d4b0f
commit 48794c4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/js/filters.js b/js/filters.js
@@ -1,15 +1,16 @@
 const filters = document.querySelector('.img-filters');
 const filtersButtons = filters.querySelectorAll('.img-filters__button');
+const ACTIVE_BUTTON_CLASS = 'img-filters__button--active';
 
 
 const showFilters = () => filters.classList.remove('img-filters--inactive');
 
 const setFilterClick = (cb) => {
   filters.addEventListener('click', (evt) => {
-    if(evt.target.classList.contains('img-filters__button') && !evt.target.classList.contains('img-filters__button--active')) {
-      filtersButtons.forEach((button) => button.classList.remove('img-filters__button--active'));
+    if(evt.target.classList.contains('img-filters__button') && !evt.target.classList.contains(ACTIVE_BUTTON_CLASS)) {
+      filtersButtons.forEach((button) => button.classList.remove(ACTIVE_BUTTON_CLASS));
       const currentFilter = evt.target;
-      currentFilter.classList.add('img-filters__button--active');
+      currentFilter.classList.add(ACTIVE_BUTTON_CLASS);
       const dataFilterId = currentFilter.getAttribute('id');
       cb(dataFilterId);
     }

diff --git a/js/render-photos.js b/js/render-photos.js
@@ -20,15 +20,6 @@ const createThumbnail = (photo) => {
   return thumbnail;
 };
 
-const getPhotoLikes = (photo) => photo.likes;
-
-const comparePhotos = (photoA, photoB) => {
-  const likesA = getPhotoLikes(photoA);
-  const likesB = getPhotoLikes(photoB);
-  return likesB - likesA;
-};
-
-
 const getPhotosToRender = (photos, filter) => {
   let photosToRender = [];
   let copyPhotos = photos.slice();
@@ -40,7 +31,7 @@ const getPhotosToRender = (photos, filter) => {
     }
     return photosToRender;
   } else if (filter === 'filter-discussed') {
-    photosToRender = copyPhotos.sort(comparePhotos).slice(0, PHOTO_NUMBERS_DEFAULT);
+    photosToRender = copyPhotos.sort((a,b) => b.comments.length - a.comments.length).slice(0, PHOTO_NUMBERS_DEFAULT);
     return photosToRender;
   }
   photosToRender = copyPhotos.slice(0, PHOTO_NUMBERS_DEFAULT);