Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Maintainer Spring clean: Dependency and Github workflow updates #79

Merged
merged 7 commits into from
Sep 23, 2023
Merged

New Maintainer Spring clean: Dependency and Github workflow updates #79

merged 7 commits into from
Sep 23, 2023

Conversation

henricook
Copy link
Collaborator

No description provided.

armanbilge
armanbilge reviewed Sep 23, 2023
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@henricook henricook changed the title New Maintainer: Spring clean New Maintainer: Spring clean. Dependency and Github workflow updates Sep 23, 2023
@henricook henricook changed the title New Maintainer: Spring clean. Dependency and Github workflow updates New Maintainer Spring clean: Dependency and Github workflow updates Sep 23, 2023
@henricook
Copy link
Collaborator Author

@armanbilge Green build - WDYT? I'd look to release 0.23.23 after this gets merged. Have I missed anything that's required before making a new release in GH?

@henricook henricook marked this pull request as ready for review September 23, 2023 18:03
@armanbilge
Copy link
Member

I'd look to release 0.23.23

I think the next version is 0.23.12, since the last release was 0.23.11.

@henricook
Copy link
Collaborator Author

henricook commented Sep 23, 2023 •
edited
Loading

I'd look to release 0.23.23

I think the next version is 0.23.12, since the last release was 0.23.11.

Ah, I thought I should keep releasing in sync with http4s versioning. If it's fine to be out of sync with http4s then all good, can do 0.23.12.

armanbilge
armanbilge reviewed Sep 23, 2023
View reviewed changes
build.sbt Show resolved Hide resolved
@armanbilge
Copy link
Member

If it's fine to be out of sync with http4s then all good, can do 0.23.12.

Yes, there's no reason to stay in sync, and in the long term it will not be sustainable. What would happen if you need to release a bug fix, how can you do it without http4s releasing first?

armanbilge
armanbilge approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@henricook henricook merged commit 74d1abb into main Sep 23, 2023
14 checks passed
@armanbilge armanbilge deleted the revivify branch September 23, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henricook @armanbilge