Skip to content

Commit

Permalink
update NEWS and cran-comments
Browse files Browse the repository at this point in the history
  • Loading branch information
hturner committed Dec 6, 2017
1 parent 1f74b66 commit 52c0ba8
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 1 deletion.
32 changes: 31 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,34 @@
# PlackettLuce 0.2
# PlackettLuce 0.2-1

## New features

* Add **pkgdown** site.
* Add content to README (fixes #5).
* Add `plot.PlackettLuce` method so that plotting works for a saved
`"PlackettLuce"` object

## Improvements

* Improved vignette, particularly example based on `beans` data (which has been
updated).
* Improved help files particularly `?PlackettLuce` and new
`package?PlackettLuce`. (Fixes #14 and #21).

## Changes in behaviour

* `maxit` defaults to 500 in `PlackettLuce`.
* Steffensen acceleration only applied in iterations where it will increase the
log-likelihood (still only attempted once iterations have reached a solution
that is "close enough" as specified by `steffensen` argument).

## Bug fixes

* `coef.pltree()` now respects `log = TRUE` argument (fixes #19).
* Fix bug causes lack of convergence with iterative scaling plus
pseudo-rankings.
* `[.grouped_rankings]` now works for replicated indices.

# PlackettLuce 0.2-0

## New Features

Expand Down
28 changes: 28 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
## Test environments

* Local
- Ubuntu 14.04, R 3.4.3
- Ubuntu 14.04, R Under development (unstable) (2017-12-04 r73829)
- Windows 8, R 3.4.3

* Via R-hub
- Mac OS 10.11 El Capitan, R-release (experimental)

## Comments

On Mac/Ubuntu, R CMD check only returns note that this is a new submission.

On Windows, R CMD check returns the same note in the log, however in the
terminal there is the following warning:

* checking CRAN incoming feasibility ...Warning: running command '"pandoc
" "C:\Users\hturner\PlackettLuce.Rcheck\00_pkg_src\PlackettLuce\README.md
" -s --email-obfuscation=references --self-contained -o "C:\Users\hturner
\AppData\Local\Temp\RtmpyQZw3Z\READMEcf025d05abf.html"' had status 99

The warning seems to be due to pandoc not finding image files in `man/figures`.
I could successfully run the pandoc command by either changing directory to
"C:\Users\hturner\PlackettLuce.Rcheck\00_pkg_src\PlackettLuce" and calling
pandoc on "README.md", or adding `--resource-path
"C:\Users\hturner\PlackettLuce.Rcheck\00_pkg_src\PlackettLuce` to the call shown
in the warning.

0 comments on commit 52c0ba8

Please sign in to comment.