update NEWS/cran comments

hturner · Sep 5, 2019 · 62ee8fb · 62ee8fb
1 parent 56f88dc
commit 62ee8fb
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,7 +1,7 @@
 # PlackettLuce 0.2-8
 
 * Fix bug in `as.rankings.matrix()`.
-* import `eigs` from RSpectra vs rARPACK.
+* Import `eigs` from RSpectra vs rARPACK.
 
 # PlackettLuce 0.2-7
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,9 +1,12 @@
+## Comments
+
+This is a re-submission fixing a bug that was found by an example in one of the reverse dependencies: ClimMobTools. This version causes warnings in ClimMobTools due to deprecated functions, which the authors have fixed in their development version (0.2-7, https://github.com/agrobioinfoservices/ClimMobTools).
+
 ## Test environments
 
 * Ubuntu 18.04.2 LTS, R 3.6.1
-* Via Win-builder
- - Windows Server 2008 (64-bit), R-devel
+* Via Win-builder: Windows Server 2008 (64-bit), R-devel
 
 ### Check results
 
-No errors, warnings or notes.
+The Win-builder check returns a note regarding URLs/DOIs that is a false alarm, all the links redirect to valid pages on jstor.
diff --git a/docs/news/index.html b/docs/news/index.html
diff --git a/vignettes/render.R b/vignettes/render.R
@@ -40,6 +40,8 @@ build_articles(lazy = FALSE) #vignette
 
 build_home()
 
+build_news()
+
 build_reference_index()
 
 build_reference() #Rd files