-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Add kjitosolsol and kmsolsol raydium tokens #392
Conversation
Rate Limit Exceeded@andreihrs has exceeded the limit for the number of files or commits that can be reviewed per hour. Please wait 15 minutes and 42 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, convert this PR to a draft and then mark it as ready for review again to re-trigger the review. Alternatively, you can push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per repository. WalkthroughThe changes primarily involve the addition of two new tokens, 'kSOLJITOSOLRaydium' and 'kSOLMSOLRaydium', across various modules in the Changes
TipsChat with CodeRabbit Bot (
|
464d36d
to
608ce17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (4)
- packages/scope-sdk/src/Scope.ts (2 hunks)
- packages/scope-sdk/src/constants/Mints.ts (1 hunks)
- packages/scope-sdk/src/constants/ScopePairs.ts (1 hunks)
- packages/scope-sdk/src/constants/SupportedToken.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/scope-sdk/src/constants/ScopePairs.ts
Additional comments (Suppressed): 4
packages/scope-sdk/src/constants/SupportedToken.ts (1)
- 119-120: The new tokens 'kSOLJITOSOLRaydium' and 'kSOLMSOLRaydium' have been added to the
SupportedTokens
array. Ensure that these tokens are indeed supported and that their names are correctly spelled and formatted.packages/scope-sdk/src/constants/Mints.ts (1)
- 88-89: The new tokens 'kSOLJITOSOLRaydium' and 'kSOLMSOLRaydium' have been added with their respective mint addresses. Ensure that these mint addresses are correct and that they correspond to the correct tokens on the Solana blockchain. Also, verify that these tokens are supported in all parts of the application where tokens are used, not just in the
Scope
SDK.packages/scope-sdk/src/Scope.ts (2)
146-147: The new tokens 'kSOLJITOSOLRaydium' and 'kSOLMSOLRaydium' have been added correctly to the array. Ensure that the
id
values are unique and sequential to maintain consistency. Also, verify that thepair
andname
values are correct and match the actual token names.404-410: The change from an object to an array in the type definition seems to be a significant alteration. Please verify that this change is intentional and that it doesn't break any existing functionality that relies on the previous object structure. Also, ensure that all parts of the code that interact with this type have been updated to handle an array instead of an object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (4)
- packages/scope-sdk/src/Scope.ts (2 hunks)
- packages/scope-sdk/src/constants/Mints.ts (1 hunks)
- packages/scope-sdk/src/constants/ScopePairs.ts (1 hunks)
- packages/scope-sdk/src/constants/SupportedToken.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/scope-sdk/src/constants/ScopePairs.ts
Additional comments (Suppressed): 4
packages/scope-sdk/src/constants/SupportedToken.ts (1)
- 116-121: The new tokens 'kSOLJITOSOLRaydium' and 'kSOLMSOLRaydium' have been added to the
SupportedTokens
array. Ensure that these tokens are valid and supported by the system. Also, verify that these tokens are correctly integrated into other parts of the system that use theSupportedTokens
array.packages/scope-sdk/src/constants/Mints.ts (1)
- 88-89: The new tokens 'kSOLJITOSOLRaydium' and 'kSOLMSOLRaydium' have been added with their respective mint addresses. Ensure that these mint addresses are correct and valid on the Solana blockchain. Also, verify that these tokens are intended to be supported across all clusters, as they are added to the default cluster.
packages/scope-sdk/src/Scope.ts (2)
146-147: The new tokens 'kSOLJITOSOLRaydium' and 'kSOLMSOLRaydium' have been added to the pairs array. Ensure that these tokens are supported and their prices can be fetched from the price feed system. Also, verify that the 'id' values are unique and correctly incremented.
404-410: The structure of the object passed to the function has been changed from an object to an array of objects. Ensure that all calls to this function throughout the codebase have been updated to match the new signature. Also, verify that the function can handle multiple objects in the array.
Summary by CodeRabbit
These updates aim to broaden the software's functionality and improve its data handling capabilities, offering users a more diverse and efficient trading experience.