floor decimals on check expected balances #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes introduced in this pull request primarily focus on enhancing the calculation and logging of expected token balances in the Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/kamino-sdk/src/Kamino.ts (1} hunks)
Additional comments: 1
packages/kamino-sdk/src/Kamino.ts (1)
- 2890-2895: The new approach to calculate
expectedALamportsandexpectedBLamportsby flooring the decimal values is a significant change. Ensure that this change doesn't introduce any rounding errors or inaccuracies in theCheckExpectedVaultsBalancesArgsobject. Also, consider removing the console log statements after you finish debugging to maintain code cleanliness.- console.log('expectedALamportsDecimal ', expectedALamportsDecimal.toString()); - console.log('expectedBLamportsDecimal ', expectedBLamportsDecimal.toString());Committable suggestion (Beta)
let expectedALamportsDecimal = collToLamportsDecimal(expectedABalance, strategyState.tokenAMintDecimals.toNumber()); let expectedBLamportsDecimal = collToLamportsDecimal(expectedBBalance, strategyState.tokenBMintDecimals.toNumber()); let expectedALamports = expectedALamportsDecimal.floor(); let expectedBLamports = expectedBLamportsDecimal.floor(); const args: CheckExpectedVaultsBalancesArgs = { tokenAAtaBalance: new BN(expectedALamports.toString()),
peroxy
approved these changes
Oct 26, 2023
| let expectedBLamports = collToLamportsDecimal(expectedBBalance, strategyState.tokenBMintDecimals.toNumber()); | ||
| let expectedALamportsDecimal = collToLamportsDecimal(expectedABalance, strategyState.tokenAMintDecimals.toNumber()); | ||
| let expectedBLamportsDecimal = collToLamportsDecimal(expectedBBalance, strategyState.tokenBMintDecimals.toNumber()); | ||
| console.log('expectedALamportsDecimal ', expectedALamportsDecimal.toString()); |
There was a problem hiding this comment.
I would remove the logs from the SDK
There was a problem hiding this comment.
I thought to keep it for a few days just in case this keeps happening and then remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Please note, these changes are under-the-hood improvements and won't affect the user interface or user experience directly. However, they contribute to the overall performance and reliability of the system.