Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get price by mint methods from kamino-sdk #406

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

peroxy
Copy link
Collaborator

@peroxy peroxy commented Nov 1, 2023

Summary by CodeRabbit

Refactor:

  • Removed several functions from the Kamino class, including getPriceByMint, getTwapByMint, getPricesByMints, and getTwapsByMints. This change indicates a shift in how token prices and Time-Weighted Average Prices (TWAPs) are retrieved, which may affect how users interact with these data.

Tests:

  • Removed a test case related to the retrieval of Kamino price and TWAP by mint. This change aligns with the refactoring of the Kamino class and does not impact the overall functionality of the code.

Copy link

coderabbitai bot commented Nov 1, 2023

Walkthrough

The codebase has undergone a significant change with the removal of several functions from the Kamino class. These functions were primarily used for retrieving token prices and TWAPs. The corresponding test cases have also been removed, indicating a shift in the approach to price and TWAP retrieval.

Changes

File Path Summary
.../src/Kamino.ts Several functions (getPriceByMint, getTwapByMint, getPricesByMints, getTwapsByMints) have been removed from the Kamino class. These functions were used to retrieve token prices and TWAPs.
.../tests/kamino.test.ts A test case that retrieves the Kamino price and twap by mint has been removed, along with related assertions.

🍂 As November winds blow, changes flow, 🍁

In the code, we reap what we sow. 🌾

Functions gone, yet spirits high, 🚀

Underneath the autumn sky. 🍂

Tests removed, a new path tread, 🛤️

With winter's chill just ahead. ❄️

Celebrate the change, embrace the new, 🎉

For every end, a beginning is due. 🌱


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 5ccc0c5 and 486c32b.
Files selected for processing (2)
  • packages/kamino-sdk/src/Kamino.ts (1 hunks)
  • packages/kamino-sdk/tests/kamino.test.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • packages/kamino-sdk/tests/kamino.test.ts
Additional comments: 1
packages/kamino-sdk/src/Kamino.ts (1)
  • 1751-1752: The removal of the functions getPriceByMint, getTwapByMint, getPricesByMints, getTwapsByMints is a significant change. Ensure that this does not break any dependencies elsewhere in the codebase. Also, verify that the new approach for retrieving token prices and TWAPs is implemented and tested.

@peroxy peroxy merged commit 2364b7b into master Nov 1, 2023
3 checks passed
@peroxy peroxy deleted the remove-price-by-mint branch November 1, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants