Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't be as annoying in development #6

Open
technicalpickles opened this issue Feb 13, 2015 · 2 comments
Open

Don't be as annoying in development #6

technicalpickles opened this issue Feb 13, 2015 · 2 comments

Comments

@technicalpickles
Copy link
Contributor

If you have this in your external-scripts.json in development without HUBOT_HEROKU_KEEPALIVE_URL or HEROKU_URL, it will log a warning every startup which is kind of annoying.

I'm open to suggestions about shushing it. Some ideas:

  • look at NODE_ENV, and don't warn during development
  • look at a new environment variable to not warn

cc hubotio/generator-hubot#25
@technicalpickles
Copy link
Contributor Author

also cc hubotio/hubot#827 @mal since it's a bit of a tangent.

treby added a commit to treby/hubot-heroku-keepalive that referenced this issue Apr 21, 2015
@treby
Skip if NODE_ENV environment is "development".
250cd97 
Fix hubot-archive#6
@treby treby mentioned this issue Apr 21, 2015
Closed
@technicalpickles
Copy link
Contributor Author

Another idea I had for this is to support setting HUBOT_HEROKU_KEEPALIVE_URL=false to disable. That way, if it's unset, it'll prompt you to configure it with a real URL or false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip if NODE_ENV environment is "development". treby/hubot-heroku-keepalive
1 participant
@technicalpickles