Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip if NODE_ENV environment is "development". #7

Closed

Conversation

treby
Copy link
Collaborator

@treby treby commented Apr 21, 2015

Hi! I tried to fix #6.
This patch provides an option. During set NODE_ENV as 'development', skip process without warning; Implementation for Plan A of #6

  • look at NODE_ENV, and don't warn during development

But actually, I have a concern.
As a default, Heroku does not provide NODE_ENV environment.
Many hubot users don't use NODE_ENV on both production(Heroku) and development(local machine) normally, I think. Then should we create brand-new environment variable? My opinion is "less is better", but there is little difference in this case.

I may need your advice.
Thanks.

@technicalpickles
Copy link
Contributor

Nice, that should help with #6 !

I think the only thing left is to document how to set that in development. Unfortunately, I don't think our hubot generator or documentation does a good job of setting up or documenting how to set those.

@technicalpickles
Copy link
Contributor

Many hubot users don't use NODE_ENV on both production(Heroku) and development(local machine) normally, I think. Then should we create brand-new environment variable?

I suggested this in #6: Another idea I had for this is to support setting HUBOT_HEROKU_KEEPALIVE_URL=false to disable. That way, if it's unset, it'll prompt you to configure it with a real URL or false.

That would avoid having another environment variable.

@treby
Copy link
Collaborator Author

treby commented Aug 24, 2015

It seems good idea! We can avoid the error with that simple way. So I close this p-r that no longer necessary. thanks :)

@treby treby closed this Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Don't be as annoying in development
2 participants