Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pager trigger unicode compatible #116

Merged
merged 2 commits into from
Nov 17, 2018
Merged

Make pager trigger unicode compatible #116

merged 2 commits into from
Nov 17, 2018

Commits on Nov 17, 2018

  1. Problem: Pager Trigger's regex isn't matching the quoted portion due … 

    …to some modern OSes converting ASCII double quote and apostrophe to "left/right double quote" and "left/right single quote". i.e. U+0022 gets converted to U+201C/U+201D and U+0027 gets converted to U+2018/U+2019.

Solution: Extend the regex to allow these unicode characters to deliniate the pager duty schedule.
    Ben Zarzycki committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    a38ba92 View commit details
    Browse the repository at this point in the history

  2. Update tests

    Ben Zarzycki committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    4c5d670 View commit details
    Browse the repository at this point in the history