[LoRA] enable LoRA for Mochi-1 #9943
Open
+522
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
commented
Nov 17, 2024
| @@ -2362,7 +2362,7 @@ def save_lora_weights( | |||
|
|
|||
| class CogVideoXLoraLoaderMixin(LoraBaseMixin): | |||
| r""" | |||
| Load LoRA layers into [`CogVideoXTransformer3DModel`]. Specific to [`CogVideoX`]. | |||
| Load LoRA layers into [`CogVideoXTransformer3DModel`]. Specific to [`CogVideoXPipeline`]. | |||
There was a problem hiding this comment.
Unrelated change but doesn't hurt I guess.
sayakpaul
commented
Nov 17, 2024
| @@ -2667,6 +2667,314 @@ def unfuse_lora(self, components: List[str] = ["transformer", "text_encoder"], * | |||
| super().unfuse_lora(components=components) | |||
|
|
|||
|
|
|||
| class Mochi1LoraLoaderMixin(LoraBaseMixin): | |||
There was a problem hiding this comment.
A copy-paste of the Cog LoRA loader classes, indicated by the "Copied from ..." comments.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
reviewed
Nov 18, 2024
| def test_simple_inference_with_text_denoiser_lora_unfused(self): | ||
| super().test_simple_inference_with_text_denoiser_lora_unfused(expected_atol=9e-3) | ||
|
|
||
| @unittest.skip("Not supported in Mochi.") |
There was a problem hiding this comment.
Looks good since not supporting T5 finetuning!
a-r-r-o-w
approved these changes
Nov 18, 2024
@a-r-r-o-w thanks! Do you think it could make sense to merge regardless with the tests, etc.? Because this will also allow others to experiment from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Needed for fine-tuning.