Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beta and exponential sigmas + add tests #9954

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hlky
Copy link
Contributor

@hlky hlky commented Nov 18, 2024

What does this PR do?

  • log_sigmas moved out of karras branch
  • _convert_to_exponential and _convert_to_beta return np.ndarray for consistency with _convert_to_karras and other code
  • Just use num_inference_steps for input to _convert_to_exponential and _convert_to_beta, not all schedulers update self.num_inference_steps

Fixes #9951

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yiyixuxu @vladmandic

@vladmandic
Copy link
Contributor

that was fast! :)

@sayakpaul
Copy link
Member

@vladmandic could you confirm if this is working for you?

@hlky this is extraordinarily fast! Thank you so much!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All schedulers have broken beta and exponential sigma methods
4 participants