-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set endpoint value from env var #50
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
When was this feature released, I also need this feature. HuggingFace is blocked in China |
Never know, not one of the maintainers. The crate hasn't released new version for six months. |
Perhaps we need fork a chinese version |
Adding this to |
@Narsil @McPatate Dear maintainers, this feature is very important for people living in places where https://huggingface.co/ is blocked such as in China. A very easy workaround in these situations is to set There are of course other ways to access Hugging Face when it is blocked. Unfortunately that requires the usage of proxy or VPN, which might be troublesome to set up considering that downstream projects like text-embeddings-inference are frequently run on containers and servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! small nit on the code
Co-authored-by: Luc Georges <McPatate@users.noreply.github.com>
Seems like the comment has been taken care of @McPatate can you take a look? |
+1 on this PR! Thanks @Adamska1008 |
If environment variable
HF_ENDPOINT
exists, use it to build api.fix #47