-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diffusionkit to local-apps #875
base: main
Are you sure you want to change the base?
Add diffusionkit to local-apps #875
Conversation
e23ea90
to
0436d98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for opening this PR and sorry for the delay. Conceptually approving the PR as the snippet looks good to me.
Will let @enzostvs chime in about what else is needed w.r.t to showing the snippet for the Local App itself.
Note: Please make sure to run the linter to make the linter tests pass.
Hi @ardaatahan, I'll need your logo in |
{ | ||
title: "Install from pip", | ||
setup: "pip install diffusionkit", | ||
content: command("diffusionkit-cli"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if binary is always the same mayber simpler to hardcode it a const command = string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's maybe wait till the binary is packaged w/o pip for us to ship this one (as it's a bit redundant with the model-library, imo)
(also cc @Wauplin given #869 (review)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to summarise discussions on next steps w/ @ZachNagengast @atiorh
Argmax will put DiffusionKit over on brew and we'll update snippets accordingly.
Opening this PR as per @Vaibhavs10's suggestion here regarding DiffusionKit LocalApps integration.
This PR:
diffusionkit
to the LOCAL_APPS object in local-apps.ts.snippetDiffusionKit
function that generates the snippet string fordiffusionkit
in the same file.