Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanotron tests #160

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

zzhhjjj
Copy link

@zzhhjjj zzhhjjj commented Apr 19, 2024

Tests for Nanotron can be conducted in both full and lite modes. Tasks can be defined by modifying the configuration file

@clefourrier
Copy link
Member

Hi @zzhhjjj !
Thanks a lot for the PR!
You'll need to pull (I merged main in your branch to update it) and run our pre-commit hook to make sure the code style is correct.
I'll take a look asap :)

@clefourrier
Copy link
Member

Tests are failing because you also need to add nanotron installation for our test suite :)
You need to add nanotron after dev, at this line

@zzhhjjj
Copy link
Author

zzhhjjj commented Apr 19, 2024

Please wait a little bit to execute tests, I still need to change the nanotron code. Already made a PR to nanotron

@clefourrier
Copy link
Member

No problem! Ping me when it's good

@clefourrier
Copy link
Member

Hi @zzhhjjj !

Do you know where you are relative to this PR? :)

@clefourrier clefourrier mentioned this pull request Aug 16, 2024
@clefourrier clefourrier mentioned this pull request Sep 14, 2024
@clefourrier clefourrier marked this pull request as draft November 14, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants