Add llama 31 support updated #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Llama 3.1 in test_decode.py Set generation_config._eos_token_tensor to None
Add llama 31 support updated
tengomucho
requested changes
Sep 11, 2024
| @@ -118,6 +118,7 @@ def create( | |||
| ) | |||
| generation_config.max_length = max_seq_length | |||
|
|
|||
| generation_config._eos_token_tensor = None | |||
There was a problem hiding this comment.
As said here, could you replace this by this snippet?
Suggested change
| generation_config._eos_token_tensor = None | |
| generation_config._eos_token_tensor = getattr(generation_config, "_eos_token_tensor", None) |
There was a problem hiding this comment.
@tengomucho Above is review is from the old PR. It is already updated. 10f857c. I have replaced the snippet in here
There was a problem hiding this comment.
sorry, I somehow missed it, it's fine then!
tengomucho
approved these changes
Sep 11, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Add workaround for eos_token_tensor in jetstream_pt_support
tengomucho
approved these changes
Sep 11, 2024
|
@Bihan any plan to rebase/fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is an updated version closed PR. This includes recent updates made in main branch.