Skip to content

Commit

Permalink
CI testing BNB: remove single GPU tests (#1866)
Browse files Browse the repository at this point in the history
CI testing BNB: remove single GPU tests

In #1859, we checked removing the import checks, but the single-GPU BNB
multi-backend branch is still stuck. Therefore, check commenting the next
step instead.

Also, add timeout of 60 min. Successful jobs currently take ~30 min. Default
timeout is 360 minutes.
  • Loading branch information
BenjaminBossan committed Jun 18, 2024
1 parent 5194aef commit 717db6e
Showing 1 changed file with 24 additions and 22 deletions.
46 changes: 24 additions & 22 deletions .github/workflows/nightly-bnb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ env:

jobs:
run_all_tests_single_gpu:
timeout-minutes: 60
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -47,40 +48,40 @@ jobs:
cd ..
fi
- name: Test bnb import
id: import
if: always()
run: |
source activate peft
python3 -m bitsandbytes
python3 -c "import bitsandbytes as bnb"
- name: Post to Slack
if: always()
uses: huggingface/hf-workflows/.github/actions/post-slack@main
with:
slack_channel: ${{ secrets.BNB_SLACK_CHANNEL_ID }}
title: 馃 Results of bitsandbytes import
status: ${{ steps.examples_tests.outcome }}
slack_token: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }}

# TODO: uncomment this block if error is solved or bnb multi backend branch is merged
# - name: Test bnb import
# id: import
# - name: Run examples on single GPU
# id: examples_tests
# if: always()
# run: |
# source activate peft
# python3 -m bitsandbytes
# python3 -c "import bitsandbytes as bnb"
# make tests_examples_single_gpu_bnb

# - name: Post to Slack
# if: always()
# uses: huggingface/hf-workflows/.github/actions/post-slack@main
# with:
# slack_channel: ${{ secrets.BNB_SLACK_CHANNEL_ID }}
# title: 馃 Results of bitsandbytes import
# status: ${{ steps.import.outcome }}
# title: 馃 Results of bitsandbytes examples tests - single GPU
# status: ${{ steps.examples_tests.outcome }}
# slack_token: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }}

- name: Run examples on single GPU
id: examples_tests
if: always()
run: |
source activate peft
make tests_examples_single_gpu_bnb
- name: Post to Slack
if: always()
uses: huggingface/hf-workflows/.github/actions/post-slack@main
with:
slack_channel: ${{ secrets.BNB_SLACK_CHANNEL_ID }}
title: 馃 Results of bitsandbytes examples tests - single GPU
status: ${{ steps.examples_tests.outcome }}
slack_token: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }}

- name: Run core tests on single GPU
id: core_tests
if: always()
Expand Down Expand Up @@ -136,6 +137,7 @@ jobs:
python scripts/log_reports.py --slack_channel_name bnb-daily-ci-collab >> $GITHUB_STEP_SUMMARY
run_all_tests_multi_gpu:
timeout-minutes: 60
strategy:
fail-fast: false
matrix:
Expand Down

0 comments on commit 717db6e

Please sign in to comment.