Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeiT, CLIP and Git interpolation added #30649

Closed

Conversation

nileshkokane01
Copy link
Contributor

@nileshkokane01 nileshkokane01 commented May 4, 2024

What does this PR do?

Fixes #30579 for Deit, Git and CLIP

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@nileshkokane01 nileshkokane01 changed the title Deit, clip and git models added Deit, clip and Git models added May 4, 2024
@nileshkokane01 nileshkokane01 changed the title Deit, clip and Git models added Deit, CLIP and Git models added May 4, 2024
@nileshkokane01 nileshkokane01 changed the title Deit, CLIP and Git models added Deit, CLIP and Git interpolation added May 4, 2024
@nileshkokane01 nileshkokane01 changed the title Deit, CLIP and Git interpolation added DeiT, CLIP and Git interpolation added May 4, 2024
@amyeroberts
Copy link
Collaborator

Hi @nileshkokane01, thanks for opening this PR!

Let's split this up so there's no too many (unrelated) models being added at once.

For the CLIP models, we should run make fix-copies and propogate the changes to all the affected models

@nileshkokane01
Copy link
Contributor Author

closed in the favor of #30783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community contribution: enable dynamic resolution input for more vision models.
2 participants