add back dontrun for glyph and add cran comments for this

huizezhang-sherry · Apr 21, 2022 · a7541ca · a7541ca
1 parent 7c0497d
commit a7541ca
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/R/map-glyph.R b/R/map-glyph.R
@@ -20,6 +20,7 @@
 #' @rdname glyph
 #' @return a ggplot object
 #' @examples
+#' \dontrun{
 #' library(ggplot2)
 #' # basic glyph map with reference line and box---------------
 #' ggplot(data = GGally::nasa,
@@ -50,6 +51,7 @@
 #' y_major = lat, y_minor = surftemp),
 #' width = rel(0.8), height = 1) +
 #' theme_bw()
+#' }
 #'
 geom_glyph <- function(mapping = NULL, data = NULL, stat = "identity",
  position = "identity", ..., x_major = NULL,

diff --git a/cran-comments.md b/cran-comments.md
@@ -6,3 +6,4 @@ Duration: 2m 3.1s
 R CMD check succeeded
 
 * This is a new release.
+* The glyph examples take ~8s to run, which is beyond the 5s limit of CRAN check, hence it is wrapped in \dontrun.
diff --git a/man/glyph.Rd b/man/glyph.Rd