Allow passing arguments to update_cubble() #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sherry,
I was looking for a function where I could update the key and index of a cubble and bumped into
update_cubble()
.However, internally the key, index, etc. are preset to the original values from the data object. Adding a simple check for NULL values would allow to pass the arguments and in fact update the cubble. This would be mainly helpful for me since
new_spatial_cubble()
is not exported. I hope this doesn't break anything, I did not test much yet.