Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing arguments to update_cubble() #33

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

loreabad6
Copy link
Contributor

Hi Sherry,

I was looking for a function where I could update the key and index of a cubble and bumped into update_cubble().
However, internally the key, index, etc. are preset to the original values from the data object. Adding a simple check for NULL values would allow to pass the arguments and in fact update the cubble. This would be mainly helpful for me since new_spatial_cubble() is not exported. I hope this doesn't break anything, I did not test much yet.

@huizezhang-sherry huizezhang-sherry merged commit 12e62f9 into huizezhang-sherry:main Aug 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants