Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

408 v380 battery sensor #411

Merged
merged 4 commits into from
Dec 27, 2024
Merged

408 v380 battery sensor #411

merged 4 commits into from
Dec 27, 2024

Conversation

hultenvp
Copy link
Owner

No description provided.

@hultenvp hultenvp linked an issue Dec 27, 2024 that may be closed by this pull request
V3.8.0 Battery sensor #408
Closed
@hultenvp hultenvp requested a review from jmason December 27, 2024 15:32
@hultenvp
Copy link
Owner Author

@jmason I missed your PR was incomplete. It does parse the values, but does not parse the unit of measurement, causing #408.
This PR adds constants for units of measurements, parses it and converts to kWh when necessary.
(HA can only work with a constant unit of measurement, so I stuck to kWh)

@hultenvp hultenvp requested review from patduckless and removed request for jmason December 27, 2024 15:59
@hultenvp hultenvp merged commit d964b10 into master Dec 27, 2024
2 checks passed
@hultenvp hultenvp deleted the 408-v380-battery-sensor branch December 27, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patduckless patduckless patduckless approved these changes

@jmason jmason jmason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V3.8.0 Battery sensor
3 participants
@hultenvp @jmason @patduckless