Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url_fopen option checking to requirements #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmgawel
Copy link

@dmgawel dmgawel commented Feb 27, 2020

The plugin uses stream_wrapper_register with STREAM_IS_URL flag, thus requiring allow_url_fopen to be enabled. It is a common security practice among hosting providers to disable this option as a precautionary measure. In such a setup the user only sees following error:

Unable to create directory. Is its parent directory writable by the server?

This PR adds a check during plugin init and provides appropriate error message when allow_url_fopen is disabled.

Related issue: #325

Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (978 errors, 14 warnings).

(990 notices occurred in your codebase, but were on files/lines not included in this PR.)

@joehoyle
Copy link
Member

joehoyle commented Jun 8, 2020

Great, thanks @dmgawel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants